Re: [PATCH 1/3] Updated dynamic tick patches - Fix lost tick

Srivatsa Vaddagiri
2005-09-01T11:35:13Z

On Thu, Sep 01, 2005 at 01:05:23PM +0200, Thomas Schlichter wrote:
> Yes, the only real differences are the two points mentioned in my first
> mail... I only wanted to help you fixing these.

Thanks for pointing them out. I have fixed it in the experimental version
that I have now.

> Well, that seems to be fine. If you want somebody to have a look over your
> final patch, feel free to mail me...

sure!

> I should have defined PMTMR_TICKS_PER_JIFFY like you assigned
> pm_ticks_per_jiffy (why did you use a static and constant variable and not a
> macro?):

I actually started with using the calibrated value of PMTMR_TICKS_PER_JIFFY
rather than compile time constant (as found in verify_pmtmr), but later dropped
the idea since I didnt get good results with it. After that didnt revert
back pm_ticks_per_jiffy to be a macro. But good point, will include
this in the next patch that I am trying out. Will post it if I happen
to have success :)