Re: [PATCH] MPC8xx PCMCIA driver

Marcelo Tosatti
2005-09-14T14:17:20Z

On Thu, Sep 01, 2005 at 10:53:19AM +0200, Dominik Brodowski wrote:

> > +typedef struct {
> > + u_int regbit;
> > + u_int eventbit;
> > +} event_table_t;
>
> No typedefs, please.

OK, I've converted it to a plain "struct".

I think this code is just following PCMCIA style:

typedef struct pccard_mem_map {
u_char map;
u_char flags;
u_short speed;
u_long static_start;
u_int card_start;
struct resource *res;
} pccard_mem_map;

Any reason why this typedef and similar ones in ss.h
are wanted?

PCMCIA is also using u_xxx "weird data types" extensively.