Re: [PATCH] MPC8xx PCMCIA driver

Dominik Brodowski
2005-09-01T08:53:21Z

Hi,

On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote:
> Russell: The driver is using pccard_nonstatic_ops for card window
> management, even though the driver its marked SS_STATIC_MAP (using
> mem->static_map).

This is obviously broken. Where does it fail if pccard_static_ops is used?

> +typedef struct {
> + u_int regbit;
> + u_int eventbit;
> +} event_table_t;

No typedefs, please.

Dominik