From: Nathan Lynch <nathanl@austin.ibm.com>
To: "Protasevich, Natalie" <Natalie.Protasevich@UNISYS.com>
Cc: shaohua.li@intel.com, akpm@osdl.org, zwane@arm.linux.org.uk,
hotplug_sig@lists.osdl.org, linux-kernel@vger.kernel.org,
lhcs-devel@lists.sourceforge.net, ak@suse.de
Subject: Re: [Hotplug_sig] [patch 1/1] Hot plug CPU to support physical add of new processors (i386)
Date: Thu, 1 Sep 2005 10:56:15 -0500 [thread overview]
Message-ID: <20050901155615.GS23400@localhost.localdomain> (raw)
In-Reply-To: <19D0D50E9B1D0A40A9F0323DBFA04ACCE04D0F@USRV-EXCH4.na.uis.unisys.com>
Protasevich, Natalie wrote:
> > > +#ifdef CONFIG_HOTPLUG_CPU
> > > + if (cpu_online(cpu)) {
> > > +#else
> > > if (cpu_online(cpu) || !cpu_present(cpu)) {
> > > +#endif
> > > ret = -EINVAL;
> > > goto out;
> > > }
> >
> > Why this change? I think the cpu_present check is needed for
> > ppc64 since it has non-present cpus in sysfs.
> >
>
> The new processor was never brought up, its bit is only set in
> cpu_possible_map, but not in present map.
If a cpu is physically present and is capable of being onlined it
should be marked in cpu_present_map, please. This change would break
ppc64; can you rework it?
next prev parent reply other threads:[~2005-09-01 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 15:48 [Hotplug_sig] [patch 1/1] Hot plug CPU to support physical add of new processors (i386) Protasevich, Natalie
2005-09-01 15:56 ` Nathan Lynch [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-01 16:03 Protasevich, Natalie
2005-08-31 12:13 Natalie.Protasevich
2005-09-01 15:30 ` [Hotplug_sig] " Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901155615.GS23400@localhost.localdomain \
--to=nathanl@austin.ibm.com \
--cc=Natalie.Protasevich@UNISYS.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=hotplug_sig@lists.osdl.org \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox