Re: Serial driver (serial_core.c) status messages should be set to KERN_INFO

[Ben Dooks <ben@fluff.org.uk>]

On Thu, Sep 01, 2005 at 10:38:26PM +0200, Jiri Slaby wrote:
> Alon Bar-Lev napsal(a):
> 
> >Hello,
> >
> >
> >When upgrading to 2.6.13 I've noticed that serial driver reports it 
> >status with unknown severity, causing the boot-splash to be overridden.
> >
> >
> >Please consider this modification.
> >
> >
> >Best Regards,
> >
> >Alon Bar-Lev.
> >
> >
> >At drivers/serial/serial_core.c
> >
> >
> >static inline void
> >
> >uart_report_port(struct uart_driver *drv, struct uart_port *port)
> >{
> >-        printk("%s%d", drv->dev_name, port->line);
> >+      printk(KERN_INFO + "%s%d", drv->dev_name, port->line);
> 
> plus sign between that?
> 
> >
> >        printk(" at ");
> 
> why the fellows didn't put this to the line above?
> >        switch (port->iotype) {
> >        case UPIO_PORT:
> >                printk("I/O 0x%x", port->iobase);
> 
> And what about these?

looks like they're not on a newline, so need no severity.
 
> >                break;
> >        case UPIO_HUB6:
> >                printk("I/O 0x%x offset 0x%x", port->iobase, port->hub6);
> >                break;
> >        case UPIO_MEM:
> >        case UPIO_MEM32:
> >                printk("MMIO 0x%lx", port->mapbase);
> >                break;
> >        }
> >        printk(" (irq = %d) is a %s\n", port->irq, uart_type(port));
> >}

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'