From: Tom Rini <trini@kernel.crashing.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Russell King <rmk@arm.linux.org.uk>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH 1/1] 8250_kgdb driver reworked
Date: Thu, 1 Sep 2005 14:47:20 -0700 [thread overview]
Message-ID: <20050901214720.GU3966@smtp.west.cox.net> (raw)
In-Reply-To: <1125611874.15768.79.camel@localhost.localdomain>
On Thu, Sep 01, 2005 at 10:57:54PM +0100, Alan Cox wrote:
> > +static irqreturn_t
> > +kgdb8250_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> > +{
> > + char iir;
> > +
> > + if (irq != KGDB8250_IRQ)
> > + return IRQ_NONE;
>
> How can this occur - you gave the IRQ number in the register_irq. WHy
> test for it, and if it occurs why not BUG()
Early sanity tests, dropped.
> > + /*
> > + * If there is some other CPU in KGDB then this is a
> > + * spurious interrupt. so return without even checking a byte
> > + */
> > + if (atomic_read(&debugger_active))
> > + return IRQ_NONE;
> > +
>
> Shared IRQ -> hung box.
Can you elaborate a bit more please? When we're actually in KGDB and
working on stuff we're polling so it's really just the
GDB-is-interrupting case.
> Also lose the ugly confusing macros like CURRENTPORT please to follow
> kernel style better. In fact why not keep a pointer to the 'current'
> uart to get tighter code too ?
Sure, why not.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-09-01 21:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 19:02 [PATCH 1/1] 8250_kgdb driver reworked Tom Rini
2005-09-01 19:55 ` Andrew Morton
2005-09-01 21:57 ` Alan Cox
2005-09-01 21:47 ` Tom Rini [this message]
2005-09-01 22:44 ` Alan Cox
2005-09-01 22:45 ` Tom Rini
2005-09-01 23:36 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901214720.GU3966@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox