From: Adrian Bunk <bunk@stusta.de>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
amax@us.ibm.com, ralf@linux-mips.org, starvik@axis.com
Cc: dev-etrax@axis.com
Subject: [2.6 patch] drivers/serial/crisv10.c: remove {,un}register_serial dummies
Date: Fri, 2 Sep 2005 01:12:58 +0200 [thread overview]
Message-ID: <20050901231258.GD3657@stusta.de> (raw)
In-Reply-To: <20050831103352.A26480@flint.arm.linux.org.uk>
On Wed, Aug 31, 2005 at 10:33:52AM +0100, Russell King wrote:
>...
> In addition, the following drivers declare functions of the same name.
> The maintainers of these need to look to see why, and eliminate them
> where possible.
>
> drivers/serial/crisv10.c:register_serial(struct serial_struct *req)
> drivers/serial/crisv10.c:void unregister_serial(int line)
It seems we can simply kill these dummies with this patch.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-mm1-full/drivers/serial/crisv10.c.old 2005-09-02 01:10:07.000000000 +0200
+++ linux-2.6.13-mm1-full/drivers/serial/crisv10.c 2005-09-02 01:10:27.000000000 +0200
@@ -5038,17 +5038,3 @@
/* this makes sure that rs_init is called during kernel boot */
module_init(rs_init);
-
-/*
- * register_serial and unregister_serial allows for serial ports to be
- * configured at run-time, to support PCMCIA modems.
- */
-int
-register_serial(struct serial_struct *req)
-{
- return -1;
-}
-
-void unregister_serial(int line)
-{
-}
next prev parent reply other threads:[~2005-09-01 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 9:33 [FINAL WARNING] Removal of deprecated serial functions - please update your drivers NOW Russell King
2005-08-31 13:00 ` Alan Cox
2005-08-31 12:52 ` Russell King
2005-08-31 13:38 ` Alan Cox
2005-08-31 15:49 ` Alan Cox
2005-09-01 23:12 ` Adrian Bunk [this message]
2005-09-02 15:58 ` [2.6 patch] drivers/serial/crisv10.c: remove {,un}register_serial dummies Russell King
2005-09-07 19:12 ` [FINAL WARNING] Removal of deprecated serial functions - please update your drivers NOW Max Asbock
2005-09-07 19:25 ` Russell King
2005-09-07 20:13 ` Max Asbock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901231258.GD3657@stusta.de \
--to=bunk@stusta.de \
--cc=amax@us.ibm.com \
--cc=dev-etrax@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox