From: Denis Vlasenko <vda@ilport.com.ua>
To: Greg KH <greg@kroah.com>
Cc: khali@linux-fr.org, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: i2c via686a.c: save at least 0.5k of space by long v[256] -> u16 v[256]
Date: Fri, 2 Sep 2005 08:54:37 +0300 [thread overview]
Message-ID: <200509020854.37192.vda@ilport.com.ua> (raw)
In-Reply-To: <20050901155915.GB1235@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Thursday 01 September 2005 18:59, Greg KH wrote:
> On Thu, Sep 01, 2005 at 09:10:14AM +0300, Denis Vlasenko wrote:
> > Not tested, but it's rather obvious.
>
> Except you forgot a "Signed-off-by:" line...
>
> > --- linux-2.6.12.src/drivers/i2c/chips/via686a.c.orig Sun Jun 19 16:10:10 2005
> > +++ linux-2.6.12.src/drivers/i2c/chips/via686a.c Tue Aug 30 00:21:39 2005
> > @@ -205,7 +205,7 @@ static inline u8 FAN_TO_REG(long rpm, in
> > but the function is very linear in the useful range (0-80 deg C), so
> > we'll just use linear interpolation for 10-bit readings.) So, tempLUT
> > is the temp at via register values 0-255: */
> > -static const long tempLUT[] =
> > +static const int16_t tempLUT[] =
>
> int16_t is not a proper kernel type. Do you really mean s16 instead?
Ok. Please be informed that there are lots of intNN_t's in i2c dir tho...
> Care to redo this?
Signed-off-by: Denis Vlasenko <vda@ilport.com.ua>
--
vda
[-- Attachment #2: via686a.patch --]
[-- Type: text/x-diff, Size: 673 bytes --]
--- linux-2.6.12.src/drivers/i2c/chips/via686a.c.orig Sun Jun 19 16:10:10 2005
+++ linux-2.6.12.src/drivers/i2c/chips/via686a.c Tue Aug 30 00:21:39 2005
@@ -205,7 +205,7 @@ static inline u8 FAN_TO_REG(long rpm, in
but the function is very linear in the useful range (0-80 deg C), so
we'll just use linear interpolation for 10-bit readings.) So, tempLUT
is the temp at via register values 0-255: */
-static const long tempLUT[] =
+static const s16 tempLUT[] =
{ -709, -688, -667, -646, -627, -607, -589, -570, -553, -536, -519,
-503, -487, -471, -456, -442, -428, -414, -400, -387, -375,
-362, -350, -339, -327, -316, -305, -295, -285, -275, -265,
next prev parent reply other threads:[~2005-09-02 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 6:10 i2c via686a.c: save at least 0.5k of space by long v[256] -> u16 v[256] Denis Vlasenko
2005-09-01 15:59 ` Greg KH
2005-09-02 5:54 ` Denis Vlasenko [this message]
2005-09-03 8:22 ` Jean Delvare
2005-09-03 14:13 ` [PATCH 2.6] hwmon: via686a: save 0.5k by long v[256] -> s16 v[256] Jean Delvare
2005-09-09 21:32 ` Greg KH
2005-09-10 21:00 ` Jean Delvare
2005-09-03 8:26 ` i2c via686a.c: save at least 0.5k of space by long v[256] -> u16 v[256] Jean Delvare
2005-09-03 12:51 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509020854.37192.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox