From: Andrew Morton <akpm@osdl.org>
To: Rajesh Shah <rajesh.shah@intel.com>
Cc: tom.l.nguyen@intel.com, greg@kroah.com, shaohua.li@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH]reconfigure MSI registers after resume
Date: Fri, 2 Sep 2005 15:00:34 -0700 [thread overview]
Message-ID: <20050902150034.72a60355.akpm@osdl.org> (raw)
In-Reply-To: <20050902125822.A11794@unix-os.sc.intel.com>
Rajesh Shah <rajesh.shah@intel.com> wrote:
>
> On Thu, Sep 01, 2005 at 01:59:32PM -0700, Nguyen, Tom L wrote:
> > On Thursday, September 01, 2005 1:10 PM Andrew Morton wrote:
> > > Is it not possible to do this in some single centralized place?
> > Existing pci_save_state(dev)/pci_restore_state(dev) covers only 64 bytes
> > of PCI header. One solution is to extend these APIs to cover up to 256
> > bytes. What do you think?
> >
> No, we can't have these generic functions blindly save/restore
> device specific parts of the config space (offset 64+). I know
> of several chipset devices which have read-clear or write-clear
> bits where reading/writing would have bad side effects. If at
> all the pci core does this, it needs to explicitly walk the
> capability list and save/restore the well known capability
> registers only.
>
OK, thanks. I'll drop Shaohua's
reconfigure-msi-registers-after-resume.patch while this gets sorted out.
next prev parent reply other threads:[~2005-09-02 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 20:59 [RFC/PATCH]reconfigure MSI registers after resume Nguyen, Tom L
2005-09-02 5:38 ` Greg KH
2005-09-02 19:58 ` Rajesh Shah
2005-09-02 22:00 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-02 18:51 Nguyen, Tom L
2005-09-01 20:01 Nguyen, Tom L
2005-09-01 20:10 ` Andrew Morton
2005-09-01 15:20 Nguyen, Tom L
2005-09-01 19:31 ` Andrew Morton
2005-09-02 1:03 ` Shaohua Li
2005-08-18 5:35 Shaohua Li
2005-08-31 21:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050902150034.72a60355.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox