From: viro@ZenIV.linux.org.uk
To: "David S. Miller" <davem@davemloft.net>
Cc: alan@lxorguk.ukuu.org.uk, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] more of sparc32 dependencies fallout
Date: Sat, 3 Sep 2005 00:30:53 +0100 [thread overview]
Message-ID: <20050902233053.GF5155@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20050902.130343.53230378.davem@davemloft.net>
On Fri, Sep 02, 2005 at 01:03:43PM -0700, David S. Miller wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Subject: Re: [PATCH] more of sparc32 dependencies fallout
> Date: Fri, 02 Sep 2005 21:24:08 +0100
>
> > On Gwe, 2005-09-02 at 20:12 +0100, viro@ZenIV.linux.org.uk wrote:
> > > config MOXA_SMARTIO
> > > tristate "Moxa SmartIO support"
> > > - depends on SERIAL_NONSTANDARD
> > > + depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
> > > help
> >
> >
> > Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its
> > only available as a plugin card and its apparently working
>
> He marked it BROKEN "OR" !SPARC32, not "AND".
> Also, SPARC32 supports PCI on Javastation machines.
Actually, proper fix of that breakage is embarrassingly simple - it's yet
another gratitious leftover include of asm/segment.h, so incremental to the
previos would be removal of that BROKEN and removal of bogus include from
mxser.c itself.
diff -urN RC13-git3-base/drivers/char/Kconfig current/drivers/char/Kconfig
--- RC13-git3-base/drivers/char/Kconfig 2005-09-02 14:16:04.000000000 -0400
+++ current/drivers/char/Kconfig 2005-09-02 19:20:11.000000000 -0400
@@ -175,7 +175,7 @@
config MOXA_SMARTIO
tristate "Moxa SmartIO support"
- depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
+ depends on SERIAL_NONSTANDARD
help
Say Y here if you have a Moxa SmartIO multiport serial card.
diff -urN RC13-git3-base/drivers/char/mxser.c current/drivers/char/mxser.c
--- RC13-git3-base/drivers/char/mxser.c 2005-06-17 15:48:29.000000000 -0400
+++ current/drivers/char/mxser.c 2005-09-02 19:20:05.000000000 -0400
@@ -63,7 +63,6 @@
#include <asm/system.h>
#include <asm/io.h>
#include <asm/irq.h>
-#include <asm/segment.h>
#include <asm/bitops.h>
#include <asm/uaccess.h>
prev parent reply other threads:[~2005-09-02 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 19:12 [PATCH] more of sparc32 dependencies fallout viro
2005-09-02 19:20 ` David S. Miller
2005-09-02 20:24 ` Alan Cox
2005-09-02 20:03 ` David S. Miller
2005-09-02 23:30 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050902233053.GF5155@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox