* [PATCH] more of sparc32 dependencies fallout
@ 2005-09-02 19:12 viro
2005-09-02 19:20 ` David S. Miller
2005-09-02 20:24 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: viro @ 2005-09-02 19:12 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
More stuff that got exposed to sparc32 build due to inclusion of
drivers/char/Kconfig in arch/sparc/Kconfig needs to be excluded.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
----
diff -urN RC13-zatm/drivers/char/Kconfig RC13-mxser-sparc32/drivers/char/Kconfig
--- RC13-zatm/drivers/char/Kconfig 2005-09-02 03:34:00.000000000 -0400
+++ RC13-mxser-sparc32/drivers/char/Kconfig 2005-09-02 03:34:20.000000000 -0400
@@ -175,7 +175,7 @@
config MOXA_SMARTIO
tristate "Moxa SmartIO support"
- depends on SERIAL_NONSTANDARD
+ depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
help
Say Y here if you have a Moxa SmartIO multiport serial card.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] more of sparc32 dependencies fallout
2005-09-02 19:12 [PATCH] more of sparc32 dependencies fallout viro
@ 2005-09-02 19:20 ` David S. Miller
2005-09-02 20:24 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: David S. Miller @ 2005-09-02 19:20 UTC (permalink / raw)
To: viro; +Cc: torvalds, linux-kernel
From: viro@ZenIV.linux.org.uk
Date: Fri, 2 Sep 2005 20:12:01 +0100
> More stuff that got exposed to sparc32 build due to inclusion of
> drivers/char/Kconfig in arch/sparc/Kconfig needs to be excluded.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Applied, thanks Al.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] more of sparc32 dependencies fallout
2005-09-02 20:24 ` Alan Cox
@ 2005-09-02 20:03 ` David S. Miller
2005-09-02 23:30 ` viro
0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2005-09-02 20:03 UTC (permalink / raw)
To: alan; +Cc: viro, torvalds, linux-kernel
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] more of sparc32 dependencies fallout
Date: Fri, 02 Sep 2005 21:24:08 +0100
> On Gwe, 2005-09-02 at 20:12 +0100, viro@ZenIV.linux.org.uk wrote:
> > config MOXA_SMARTIO
> > tristate "Moxa SmartIO support"
> > - depends on SERIAL_NONSTANDARD
> > + depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
> > help
>
>
> Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its
> only available as a plugin card and its apparently working
He marked it BROKEN "OR" !SPARC32, not "AND".
Also, SPARC32 supports PCI on Javastation machines.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] more of sparc32 dependencies fallout
2005-09-02 19:12 [PATCH] more of sparc32 dependencies fallout viro
2005-09-02 19:20 ` David S. Miller
@ 2005-09-02 20:24 ` Alan Cox
2005-09-02 20:03 ` David S. Miller
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2005-09-02 20:24 UTC (permalink / raw)
To: viro; +Cc: Linus Torvalds, linux-kernel
On Gwe, 2005-09-02 at 20:12 +0100, viro@ZenIV.linux.org.uk wrote:
> config MOXA_SMARTIO
> tristate "Moxa SmartIO support"
> - depends on SERIAL_NONSTANDARD
> + depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
> help
Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its
only available as a plugin card and its apparently working
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] more of sparc32 dependencies fallout
2005-09-02 20:03 ` David S. Miller
@ 2005-09-02 23:30 ` viro
0 siblings, 0 replies; 5+ messages in thread
From: viro @ 2005-09-02 23:30 UTC (permalink / raw)
To: David S. Miller; +Cc: alan, torvalds, linux-kernel
On Fri, Sep 02, 2005 at 01:03:43PM -0700, David S. Miller wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Subject: Re: [PATCH] more of sparc32 dependencies fallout
> Date: Fri, 02 Sep 2005 21:24:08 +0100
>
> > On Gwe, 2005-09-02 at 20:12 +0100, viro@ZenIV.linux.org.uk wrote:
> > > config MOXA_SMARTIO
> > > tristate "Moxa SmartIO support"
> > > - depends on SERIAL_NONSTANDARD
> > > + depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
> > > help
> >
> >
> > Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its
> > only available as a plugin card and its apparently working
>
> He marked it BROKEN "OR" !SPARC32, not "AND".
> Also, SPARC32 supports PCI on Javastation machines.
Actually, proper fix of that breakage is embarrassingly simple - it's yet
another gratitious leftover include of asm/segment.h, so incremental to the
previos would be removal of that BROKEN and removal of bogus include from
mxser.c itself.
diff -urN RC13-git3-base/drivers/char/Kconfig current/drivers/char/Kconfig
--- RC13-git3-base/drivers/char/Kconfig 2005-09-02 14:16:04.000000000 -0400
+++ current/drivers/char/Kconfig 2005-09-02 19:20:11.000000000 -0400
@@ -175,7 +175,7 @@
config MOXA_SMARTIO
tristate "Moxa SmartIO support"
- depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
+ depends on SERIAL_NONSTANDARD
help
Say Y here if you have a Moxa SmartIO multiport serial card.
diff -urN RC13-git3-base/drivers/char/mxser.c current/drivers/char/mxser.c
--- RC13-git3-base/drivers/char/mxser.c 2005-06-17 15:48:29.000000000 -0400
+++ current/drivers/char/mxser.c 2005-09-02 19:20:05.000000000 -0400
@@ -63,7 +63,6 @@
#include <asm/system.h>
#include <asm/io.h>
#include <asm/irq.h>
-#include <asm/segment.h>
#include <asm/bitops.h>
#include <asm/uaccess.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-09-02 23:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-02 19:12 [PATCH] more of sparc32 dependencies fallout viro
2005-09-02 19:20 ` David S. Miller
2005-09-02 20:24 ` Alan Cox
2005-09-02 20:03 ` David S. Miller
2005-09-02 23:30 ` viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox