public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] net/netfilter/nfnetlink*: make functions static
@ 2005-09-03  1:28 Adrian Bunk
  2005-09-03  8:27 ` [netfilter-core] " Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-09-03  1:28 UTC (permalink / raw)
  To: coreteam; +Cc: netdev, linux-kernel

This patch makes needlessly global functions static.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 net/netfilter/nfnetlink.c       |    4 ++--
 net/netfilter/nfnetlink_queue.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.13-mm1-full/net/netfilter/nfnetlink.c.old	2005-09-03 02:26:18.000000000 +0200
+++ linux-2.6.13-mm1-full/net/netfilter/nfnetlink.c	2005-09-03 02:27:21.000000000 +0200
@@ -344,14 +344,14 @@
 	} while(nfnl && nfnl->sk_receive_queue.qlen);
 }
 
-void __exit nfnetlink_exit(void)
+static void __exit nfnetlink_exit(void)
 {
 	printk("Removing netfilter NETLINK layer.\n");
 	sock_release(nfnl->sk_socket);
 	return;
 }
 
-int __init nfnetlink_init(void)
+static int __init nfnetlink_init(void)
 {
 	printk("Netfilter messages via NETLINK v%s.\n", nfversion);
 
--- linux-2.6.13-mm1-full/net/netfilter/nfnetlink_queue.c.old	2005-09-03 02:26:55.000000000 +0200
+++ linux-2.6.13-mm1-full/net/netfilter/nfnetlink_queue.c	2005-09-03 02:27:06.000000000 +0200
@@ -76,7 +76,7 @@
 
 static DEFINE_RWLOCK(instances_lock);
 
-u_int64_t htonll(u_int64_t in)
+static u_int64_t htonll(u_int64_t in)
 {
 	u_int64_t out;
 	int i;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [netfilter-core] [2.6 patch] net/netfilter/nfnetlink*: make functions static
  2005-09-03  1:28 [2.6 patch] net/netfilter/nfnetlink*: make functions static Adrian Bunk
@ 2005-09-03  8:27 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2005-09-03  8:27 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: coreteam, netdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Sat, Sep 03, 2005 at 03:28:29AM +0200, Adrian Bunk wrote:
> This patch makes needlessly global functions static.

Thanks for your patch.  I'll merge it with my local changes (it clashes,
since the "htonll" implementation was removed) and submit it via davem
later today.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-09-03  8:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-03  1:28 [2.6 patch] net/netfilter/nfnetlink*: make functions static Adrian Bunk
2005-09-03  8:27 ` [netfilter-core] " Harald Welte

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox