Re: [DVB patch 54/54] ttusb-budget: use time_after_eq()

Johannes Stezenbach
2005-09-05T00:19:31Z

On Sun, Sep 04, 2005 Nish Aravamudan wrote:
> On 9/4/05, Johannes Stezenbach <js@linuxtv.org> wrote:
> > On Sun, Sep 04, 2005 Nish Aravamudan wrote:
> > > On 9/4/05, Johannes Stezenbach <js@linuxtv.org> wrote:
> > > >
> > > > -static int numpkt = 0, lastj, numts, numstuff, numsec, numinvalid;
> > > > +static int numpkt = 0, numts, numstuff, numsec, numinvalid;
> > > > +static unsigned long lastj;
> > > >
> > >
> > > I think you actually want:
> > >
> > > static void ttusb_iso_irq(....)
> > > {
> > > unsigned long lastj;
> > >
> >
> > The code in question is used to print a one-per-second debug output,
> > and lastj is assigned after every print.
>
> Ah yes, didn't see that in the current code, sorry for that noise.
> Still, lastj is local to ttusb_iso_irq(), right?

Yes, but it needs to be static.

Johannes