Re: [DVB patch 51/54] ttpci: av7110: RC5+ remote control support

Nish Aravamudan
2005-09-05T00:16:42Z

On 9/4/05, Johannes Stezenbach <js@linuxtv.org> wrote:
> On Sun, Sep 04, 2005 Nish Aravamudan wrote:
> > On 9/4/05, Johannes Stezenbach <js@linuxtv.org> wrote:
> > > --- linux-2.6.13-git4.orig/drivers/media/dvb/ttpci/av7110_ir.c 2005-09-04 22:03:40.000000000 +0200
> > > +++ linux-2.6.13-git4/drivers/media/dvb/ttpci/av7110_ir.c 2005-09-04 22:31:00.000000000 +0200
> > > @@ -7,16 +7,16 @@
> > > #include <asm/bitops.h>
> > >
> > > #include "av7110.h"
> > > +#include "av7110_hw.h"
> > >
> > > -#define UP_TIMEOUT (HZ/4)
> > > +#define UP_TIMEOUT (HZ*7/25)
> >
> > Should this be
> >
> > #define UP_TIMEOUT msecs_to_jiffies(280)
> >
> > or
> >
> > #define UP_TIMEOUT (7*msecs_to_jiffies(40)
> >
> > ?
>
> I agree it's nicer to read, but AFAIK not required for correctness?
> If so, then we'll fix those up in linuxtv.org CVS and submit
> cleanup patches later.

Yeah, it's correct with the three current values of HZ (100, 250 and
1000), but if you try a not-so-clean value (like Con did with 864, or
something), you might run into rounding issues. msecs_to_jiffies()
should take care of them (or will be a single point to do so
eventually).

Thanks,
Nish