Re: [DVB patch 14/54] frontend: s5h1420: fixes

Andrew de Quincey
2005-09-05T08:45:22Z

On Monday 05 Sep 2005 00:56, Nish Aravamudan wrote:
> On 9/4/05, Johannes Stezenbach <js@linuxtv.org> wrote:
> > From: Andrew de Quincey <adq_dvb@lidskialf.net>
> >
> > Misc. fixes.
>
> <snip>
>
> > --- linux-2.6.13-git4.orig/drivers/media/dvb/frontends/s5h1420.c
> > 2005-09-04 22:24:24.000000000 +0200 +++
> > linux-2.6.13-git4/drivers/media/dvb/frontends/s5h1420.c 2005-09-04
> > 22:28:04.000000000 +0200
>
> @@ -138,16 +146,17 @@ static int s5h1420_send_master_cmd (stru
>
> <snip>
>
> > /* wait for transmission to complete */
> > timeout = jiffies + ((100*HZ) / 1000);
>
> <snip>
>
> > @@ -236,7 +246,7 @@ static int s5h1420_send_burst (struct dv
> > s5h1420_writereg(state, 0x3b, s5h1420_readreg(state, 0x3b) |
> > 0x08);
> >
> > /* wait for transmission to complete */
> > - timeout = jiffies + ((20*HZ) / 1000);
> > + timeout = jiffies + ((100*HZ) / 1000);
>
> Should these be
>
> timeout = jiffies + msecs_to_jiffies(100);

Yes, you're right.