Re: [PATCH 1/4] cpusets oom_kill tweaks

Coywolf Qi Hunt
2005-09-01T10:49:20Z

On 9/1/05, Paul Jackson <pj@sgi.com> wrote:
> Coywolf wrote:
> > Why bother ...
>
> The line length in characters was getting too long, the logic was

Yeah. That long line bugged me too when I was writing my lca oom-killer patch.

> getting too convoluted, and the comment only applied to an unobvious
> portion of the line.
>
> Providing a name for the logical condition that a complicated
> expression computes is one of the ways I find useful to make
> code easier to read, and to resolve problems such as those above.

Maybe.

>
> My primary goal in writing code is to minimize the time and effort
> it will take a typical reader to properly understand the code.
> I write first and foremost for humans.

Hmm, I really wish xfs guys follow that too.
--
Coywolf Qi Hunt