From: viro@ZenIV.linux.org.uk
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kconfig fix (BLK_DEV_FD dependencies)
Date: Tue, 6 Sep 2005 16:23:20 +0100 [thread overview]
Message-ID: <20050906152320.GX5155@ZenIV.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0509061701060.3743@scrub.home>
On Tue, Sep 06, 2005 at 05:05:33PM +0200, Roman Zippel wrote:
> Hi,
>
> On Tue, 6 Sep 2005 viro@ZenIV.linux.org.uk wrote:
>
> > We could go for your "allow" form, but what else would need it? USB gadget
> > stuff with its "must have at most one low-level driver, high-level drivers
> > should be allowed only if a low-level one is present"? RTC mess is better
> > solved in other ways, PARPORT_PC is mostly solved by now, what's left?
> > VGA_CONSOLE? I really don't see enough uses for such construct...
>
> It would be mostly useful for arm/mips with their millions of
> configurations. Adding or removing one of them would become easier if the
> references to it aren't spread over the complete.
> Basically select is already used (and sometimes abused) this way.
One major problem with that: unless you accept bare allow and/or select
(not as part of config <something>), we _still_ get these noise symbols,
just to have some place where that "allow" clause could live.
IOW, you get something like
config I_DONT_WANT_TO_CALL_THAT_ARCH_HAS_SOMETHING
bool
default y
allow BLK_DEV_FD
in the same places where I do
config ARCH_MIGHT_HAVE_PC_FDC
default y
with the only difference being that in your variant symbol will be 100%
semantics-free - it's just a workaround for Kconfig syntax problem.
Are you up to such change? If so, I'll just take current patch and do
pretty much a search-and-replace on it, turning unconditional instances
of these suckers (i.e. in absense of subarchitectures) into plain
# there's a glue for PC-like FDC
allow BLD_DEV_FD
If you insist on having dummy config around allow/select, I don't see any
real benefits in using "allow" form...
next prev parent reply other threads:[~2005-09-06 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 0:48 [PATCH] Kconfig fix (BLK_DEV_FD dependencies) viro
2005-09-06 10:52 ` Roman Zippel
2005-09-06 13:49 ` viro
2005-09-06 14:50 ` Geert Uytterhoeven
2005-09-06 15:05 ` Roman Zippel
2005-09-06 15:23 ` viro [this message]
2005-09-06 16:13 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050906152320.GX5155@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox