public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: akpm@osdl.org
Cc: dwmw2@infradead.org, bunk@stusta.de, johnstul@us.ibm.com,
	drepper@redhat.com, Franz.Fischer@goyellow.de,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][Bug 5132] fix sys_poll() large timeout handling
Date: Tue, 6 Sep 2005 14:25:14 -0700	[thread overview]
Message-ID: <20050906212514.GB3038@us.ibm.com> (raw)
In-Reply-To: <20050831200109.GB3017@us.ibm.com>

On 31.08.2005 [13:01:09 -0700], Nishanth Aravamudan wrote:
> Sorry everybody, forgot the most important Cc: :)
> 
> -Nish
> 
> Hi Andrew,
> 
> In looking at Bug 5132 and sys_poll(), I think there is a flaw in the
> current code.
> 
> The @timeout parameter to sys_poll() is in milliseconds but we compare
> it to (MAX_SCHEDULE_TIMEOUT / HZ), which is jiffies/jiffies-per-sec or
> seconds. That seems blatantly broken. Also, I think we are better served
> by converting to jiffies first then comparing, as opposed to converting
> our maximum to milliseconds (or seconds, incorrectly) and comparing.
> 
> Comments, suggestions for improvement?

I haven't got any responses (here or on the bug)... A silent NACK?
Anything I should change to make people happier?

Thanks,
Nish

  reply	other threads:[~2005-09-06 21:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-31 20:01 [PATCH][Bug 5132] fix sys_poll() large timeout handling Nishanth Aravamudan
2005-09-06 21:25 ` Nishanth Aravamudan [this message]
2005-09-10  0:35   ` [UPDATE PATCH][Bug " Nishanth Aravamudan
2005-09-10  1:16     ` Andrew Morton
2005-09-10  2:23       ` Nishanth Aravamudan
2005-09-10  2:36         ` Andrew Morton
2005-09-10  2:55           ` Nishanth Aravamudan
2005-09-12 14:30             ` Peter Staubach
2005-09-12 15:05               ` Nishanth Aravamudan
2005-09-12 15:19                 ` Peter Staubach
2005-09-12 16:06                   ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050906212514.GB3038@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=Franz.Fischer@goyellow.de \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=drepper@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox