From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [-mm patch 3/5] SharpSL: Abstract c7x0 specifics from Corgi Touchscreen driver
Date: Thu, 8 Sep 2005 13:10:28 +0100 [thread overview]
Message-ID: <20050908131028.B31595@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1126007630.8338.128.camel@localhost.localdomain>; from rpurdie@rpsys.net on Tue, Sep 06, 2005 at 12:53:50PM +0100
On Tue, Sep 06, 2005 at 12:53:50PM +0100, Richard Purdie wrote:
> Separate out the Sharp Zaurus c7x0 series specific code from the Corgi
> Touchscreen driver. Use the new functions in corgi_lcd.c via sharpsl.h
> for hsync handling and pass the IRQ as a platform device resource. Move
> a function prototype into the w100fb header file where it belongs.
This patch looks a little confused.
> + corgi_ts->irq_gpio = platform_get_irq(pdev, 0);
So irq_gpio is an IRQ number.
> @@ -313,14 +324,14 @@
> input_register_device(&corgi_ts->input);
> corgi_ts->power_mode = PWR_MODE_ACTIVE;
>
> - if (request_irq(CORGI_IRQ_GPIO_TP_INT, ts_interrupt, SA_INTERRUPT, "ts", corgi_ts)) {
> + if (request_irq(IRQ_GPIO(corgi_ts->irq_gpio), ts_interrupt, SA_INTERRUPT, "ts", corgi_ts)) {
Or is it. It _should_ be an IRQ number.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-09-08 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 11:53 [-mm patch 3/5] SharpSL: Abstract c7x0 specifics from Corgi Touchscreen driver Richard Purdie
2005-09-06 12:40 ` Richard Purdie
2005-09-08 12:10 ` Russell King [this message]
2005-09-08 14:56 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050908131028.B31595@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox