From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [-mm patch 5/5] SharpSL: Add new ARM PXA machines Spitz and Borzoi with partial Akita Support
Date: Thu, 8 Sep 2005 15:59:26 +0100 [thread overview]
Message-ID: <20050908155926.B5661@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1126191158.8147.61.camel@localhost.localdomain>; from rpurdie@rpsys.net on Thu, Sep 08, 2005 at 03:52:37PM +0100
On Thu, Sep 08, 2005 at 03:52:37PM +0100, Richard Purdie wrote:
> Alternatively, would you accept a patch to add an optional delay option
> to mmc_detect_change()?
Yes, since a number of hosts seem to require this (and sometimes it
even depends whether we're inserting or removing a card.)
Can I have a signed-off-by line for this patch please?
> Index: linux-2.6.13/drivers/mmc/mmc.c
> ===================================================================
> --- linux-2.6.13.orig/drivers/mmc/mmc.c 2005-09-07 22:23:01.000000000 +0100
> +++ linux-2.6.13/drivers/mmc/mmc.c 2005-09-07 22:40:03.000000000 +0100
> @@ -1067,13 +1067,17 @@
> /**
> * mmc_detect_change - process change of state on a MMC socket
> * @host: host which changed state.
> + * @delay: optional delay to wait before detection (jiffies)
> *
> * All we know is that card(s) have been inserted or removed
> * from the socket(s). We don't know which socket or cards.
> */
> -void mmc_detect_change(struct mmc_host *host)
> +void mmc_detect_change(struct mmc_host *host, unsigned long delay)
> {
> - schedule_work(&host->detect);
> + if (delay)
> + schedule_delayed_work(&host->detect, delay);
> + else
> + schedule_work(&host->detect);
> }
>
>
>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2005-09-08 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 11:53 [-mm patch 5/5] SharpSL: Add new ARM PXA machines Spitz and Borzoi with partial Akita Support Richard Purdie
2005-09-06 16:22 ` Nish Aravamudan
2005-09-08 12:23 ` Russell King
2005-09-08 14:52 ` Richard Purdie
2005-09-08 14:59 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050908155926.B5661@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox