From: viro@ZenIV.linux.org.uk
To: "David S. Miller" <davem@davemloft.net>
Cc: torvalds@osdl.org, alan@lxorguk.ukuu.org.uk,
rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org,
davem@redhat.com, akpm@osdl.org
Subject: Re: Serial maintainership
Date: Thu, 8 Sep 2005 21:31:20 +0100 [thread overview]
Message-ID: <20050908203120.GC9623@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20050908.131358.93602687.davem@davemloft.net>
On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote:
> From: Linus Torvalds <torvalds@osdl.org>
> Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
>
> > Mistakes happen, and the way you fix them is not to pull a tantrum, but
> > tell people that they are idiots and they broke something, and get them to
> > fix it instead.
>
> In all this noise I still haven't seen what is wrong with
> the build warning fix I made.
The fact that it's called regardless of SUPPORT_SYSRQ and some callers
look like
#ifdef SUPPORT_SYSRQ
int foo(blah, struct pt_regs *regs)
#else
int foo(blah)
#endif
{
...
uart_handle_sysrq_char(..., regs);
...
}
which works with old definition (without SUPPORT_SYSRQ the last argument of
uart_handle_sysrq_char() is never seen by parser) and obviously dies with
the new one.
And yes, it's sick...
prev parent reply other threads:[~2005-09-08 20:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 15:52 Serial maintainership Russell King
2005-09-08 16:38 ` Alan Cox
2005-09-08 16:25 ` Russell King
2005-09-08 19:35 ` Andrew Morton
2005-09-08 16:27 ` Linus Torvalds
2005-09-08 20:13 ` David S. Miller
2005-09-08 20:22 ` Russell King
2005-09-08 20:26 ` David S. Miller
2005-09-08 20:39 ` Linus Torvalds
2005-09-08 20:42 ` David S. Miller
2005-09-08 21:22 ` Linus Torvalds
2005-09-08 21:26 ` David S. Miller
2005-09-08 21:31 ` Russell King
2005-09-08 21:37 ` Linus Torvalds
2005-09-08 20:31 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050908203120.GC9623@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox