From: Greg KH <gregkh@suse.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, johnpol@2ka.mipt.ru
Subject: Re: [GIT PATCH] W1 patches for 2.6.13
Date: Thu, 8 Sep 2005 20:30:36 -0700 [thread overview]
Message-ID: <20050909033036.GB11369@suse.de> (raw)
In-Reply-To: <1126222209.5286.74.camel@blade>
On Fri, Sep 09, 2005 at 01:30:09AM +0200, Marcel Holtmann wrote:
> Hi Greg,
>
> > Here are some w1 patches that have been in the -mm tree for a while.
> > They add a new driver, and fix up the netlink logic a lot. They also
> > add a crc16 implementation that is needed.
>
> adding the CRC-16 is very cool. I was just about to submit one by my
> own, because it is also needed for the Bluetooth L2CAP retransmission
> and flow control support.
>
> What about the 1-Wire notes inside the CRC-16 code. This suppose to be
> generic code and so this doesn't belong there.
Yes, those comments don't belong there. Evgeniy, want to fix this?
thanks,
greg k-h
next prev parent reply other threads:[~2005-09-09 3:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 22:21 [GIT PATCH] W1 patches for 2.6.13 Greg KH
2005-09-08 23:30 ` Marcel Holtmann
2005-09-09 3:30 ` Greg KH [this message]
2005-09-09 5:08 ` Evgeniy Polyakov
2005-09-09 21:16 ` Greg KH
2005-09-09 21:58 ` Evgeniy Polyakov
2005-09-09 22:11 ` Greg KH
2005-09-12 13:12 ` [1/1] crc16: remove w1 specific comments Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909033036.GB11369@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox