From: Andi Kleen <ak@suse.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.13] x86_64: Add notify_die() to another spot in do_page_fault()
Date: Fri, 9 Sep 2005 10:01:00 +0200 [thread overview]
Message-ID: <200509091001.01325.ak@suse.de> (raw)
In-Reply-To: <20050908163840.GR3966@smtp.west.cox.net>
On Thursday 08 September 2005 18:38, Tom Rini wrote:
> This adds a call to notify_die() in the "no context" portion of
> do_page_fault() as someone on the chain might care and want to do a fixup.
>
> ---
>
> linux-2.6.13-trini/arch/x86_64/mm/fault.c | 4 ++++
> 1 files changed, 4 insertions(+)
>
> diff -puN arch/x86_64/mm/fault.c~x86_64-no_context_hook
> arch/x86_64/mm/fault.c ---
> linux-2.6.13/arch/x86_64/mm/fault.c~x86_64-no_context_hook 2005-09-01
> 12:00:43.000000000 -0700 +++
> linux-2.6.13-trini/arch/x86_64/mm/fault.c 2005-09-01 12:00:43.000000000
> -0700 @@ -514,6 +514,10 @@ no_context:
> if (is_errata93(regs, address))
> return;
>
> + if (notify_die(DIE_PAGE_FAULT, "no context", regs, error_code, 14,
> + SIGSEGV) == NOTIFY_STOP)
> + return;
> +
But how would the chain users distingush this from the DIE_PAGE_FAULT
reported at the beginning of the page fault handler? I don't see how
it can work. If anything you would need a DIE_NO_CONTEXT or somesuch, no?
-Andi
next prev parent reply other threads:[~2005-09-09 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 16:38 [PATCH 2.6.13] x86_64: Add notify_die() to another spot in do_page_fault() Tom Rini
2005-09-09 8:01 ` Andi Kleen [this message]
2005-09-09 12:47 ` Tom Rini
2005-09-09 12:52 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509091001.01325.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox