public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Tom Rini <trini@kernel.crashing.org>, jbeulich@novell.com
Cc: Andrew Morton <akpm@osdl.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Keith Owens <kaos@sgi.com>
Subject: Re: [PATCH 2.6.13] x86_64: Rename KDB_VECTOR to NMI_VECTOR
Date: Fri, 9 Sep 2005 10:06:31 +0200	[thread overview]
Message-ID: <200509091006.31824.ak@suse.de> (raw)
In-Reply-To: <20050908163928.GS3966@smtp.west.cox.net>

On Thursday 08 September 2005 18:39, Tom Rini wrote:
> The existing hook from KDB in the IPI code is really just a hook for the
> NMI vector.  We rename the vector thusly and then it's up to the
> debugger to handle things from do_default_nmi().

Jan Beulich pointed out some problems with this:

- First NMI vector is always 2 in the x86 architecture, so calling
another vector NMI_VECTOR is misleading.

- And when an NMI is forced in ICR the x86 architecture specifies
that the interrupt is delivered to vector 2.

Intel IA32  vol 3 8-23:

>>

100 (NMI) Delivers an NMI interrupt to the target processor
          or processors. The vector information is ignored.
<<

So how did this ever work?  I suspect you just got reentered
via the hooks in the NMI handler, but never through this vector.

I think I'll just remove this unless someone can explain how
it is supposed to work.

Thanks,
-Andi


      reply	other threads:[~2005-09-09  8:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-08 16:39 [PATCH 2.6.13] x86_64: Rename KDB_VECTOR to NMI_VECTOR Tom Rini
2005-09-09  8:06 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200509091006.31824.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=jbeulich@novell.com \
    --cc=kaos@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox