Re: 2.6.13-mm2

Martin J. Bligh
2005-09-12T06:09:57Z

>> Andi, does that need changing on ia32 as well as x86_64, or are you
>> just missing some ifdefs? Looks to me like the rest of the patch is
>> specific to x86_64.
>
> It should be a straight forward fix - the new zone is empty on i386.
> Ok I reviewed chunk_to_zone and it should be ok with the new empty
> zone. So just the appended patch should work. Can you test?

Will do. but did you actually mean to enable it on both arches? didn't
look like it, but maybe you did.

> -AndI
>
> Make i386 compile again with fourth DMA32 zone
>
> The code should deal with an additiona empty zone, so fix up the
># error.
>
> Signed-off-by: Andi Kleen <ak@suse.de>
>
> Index: linux/arch/i386/kernel/srat.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/srat.c
> +++ linux/arch/i386/kernel/srat.c
> @@ -137,8 +137,8 @@ static void __init parse_memory_affinity
> "enabled and removable" : "enabled" ) );
> }
>
> -#if MAX_NR_ZONES != 3
> -#error "MAX_NR_ZONES != 3, chunk_to_zone requires review"
> +#if MAX_NR_ZONES != 4
> +#error "MAX_NR_ZONES != 4, chunk_to_zone requires review"
> #endif
> /* Take a chunk of pages from page frame cstart to cend and count the number
> * of pages in each zone, returned via zones[].
>
>
>
>
>