Re: [linux-usb-devel] Re: 2.6.13-mm2

Daniel Ritz
2005-09-28T20:45:28Z

On Wednesday 28 September 2005 22.23, David Brownell wrote:
> > > > > BTW, please have a look at:
> > > > > http://bugzilla.kernel.org/show_bug.cgi?id=4416#c36
> > > > > and
> > > > > http://bugzilla.kernel.org/show_bug.cgi?id=4416#c37
>
> What's with the bogus dates in those reports ... claiming some of you
> were testing 2.6.13-rc2-mm2 more than two months ago, mid-July ?????

hu? your point is?

>
>
> > > > interesting. i'd say we get interrupt storms from usb which then hurt when
> > > > yenta has it's handler installed but usb has not. usb/hcd-pci.c frees the
> > > > irq on suspend...so it may be enough not to do that (survives suspend-to-ram
> > > > and suspend-to-disk here. yes, restore too :)
> > > >
> > > > could you give that a tree w/o any free_irq-patches for yenta and co?
> > >
> > > I've tried and it apparently works provided that _none_ of the IRQ-sharing
> > > devices drops the IRQ on suspend.
> >
> > ok. i didn't look too close, but i think ohci-hcd does not fully disable
> > interrupts in it's suspend callback...needs a closer look.
> > cc:ing linux-usb-devel...
>
> It's handled in hcd-pci.c ... All PCI based HCDs release their IRQs
> when they suspend. Including OHCI. Your diagnosis is incorrect.

would you be kind enough to tell me where?

my point is: the test patch i sent to rafael which comments out the
free_irq-on-suspend thing in hcd-pci.c shows that something is wrong with
USB (i think only OHCI. UHCI looks ok and about EHCI i have no data).

>
> - Dave
>

rgds
-daniel