Re: 2.6.13-mm2

Andi Kleen
2005-09-09T10:46:41Z

On Friday 09 September 2005 12:41, Andrew Morton wrote:
> Andi Kleen <ak@suse.de> wrote:
> > > arch/x86_64/pci/built-in.o(.init.text+0xa88): In function
`pci_acpi_scan_root':
> > > : undefined reference to `pxm_to_node'
> > >
> > > make: *** [.tmp_vmlinux1] Error 1
> > > 09/08/05-06:52:31 Build the kernel. Failed rc = 2
> > > 09/08/05-06:52:31 build: kernel build Failed rc = 1
> > > 09/08/05-06:52:31 command complete: (2) rc=126
> > > Failed and terminated the run
> >
> > I tried the config in my (non mm) tree and it compiled just fine.
>
> You must have mucked it up.

Martin put up the wrong .config. I fixed it now in my tree.
The problem was that he didn't enable ACPI_NUMA, just NUMA
and the acpi.c code only checked _NUMA

>
>
> Also, x86_64-srat-overlap-error.patch adds this forward decl in
> arch/x86_64/mm/srat.c:
>
> int node_to_pxm(int n);
>
> Please, either give it static scope or, if it really needs global scope (it
> doesn't), put the declaration in the right place?

I'll make it static.

-Andi