From: Andi Kleen <ak@suse.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bob Picco <bob.picco@hp.com>
Subject: Re: [PATCH 2.6.13] x86_64: Make trap_init() happen earlier - dropped
Date: Fri, 9 Sep 2005 16:17:40 +0200 [thread overview]
Message-ID: <200509091617.40770.ak@suse.de> (raw)
In-Reply-To: <20050908163757.GQ3966@smtp.west.cox.net>
On Thursday 08 September 2005 18:37, Tom Rini wrote:
> It can be handy in some situations to have run trap_init() sooner than the
> generic code does. In order to do this on x86_64 we need to add a custom
> early_setup_per_cpu_areas() call as well.
The patch is totally broken and causes crash even under light load
(just found it after a lengthy binary search)
>
> +void __init early_setup_per_cpu_areas(void)
> +{
> + static char cpu0[PERCPU_ENOUGH_ROOM] __cacheline_aligned
> + __attribute__ ((aligned (SMP_CACHE_BYTES)));
The original code does
/* Copy section for each CPU (we discard the original) */
size = ALIGN(__per_cpu_end - __per_cpu_start, SMP_CACHE_BYTES);
#ifdef CONFIG_MODULES
if (size < PERCPU_ENOUGH_ROOM)
size = PERCPU_ENOUGH_ROOM;
#endif
perhaps end-start is larger than PERCPU_ENOUGH_ROOM ? (using defconfig)
Dropped from my tree for now.
-Andi
next prev parent reply other threads:[~2005-09-09 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 16:37 [PATCH 2.6.13] x86_64: Make trap_init() happen earlier Tom Rini
2005-09-09 8:01 ` Andi Kleen
2005-09-09 14:17 ` Andi Kleen [this message]
2005-09-09 15:27 ` [PATCH 2.6.13] x86_64: Make trap_init() happen earlier - dropped Bob Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509091617.40770.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bob.picco@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox