From: viro@ZenIV.linux.org.uk
To: Eric Piel <Eric.Piel@lifl.fr>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, zippel@linux-m68k.org
Subject: Re: [PATCH] bogus #if (acpi/blacklist)
Date: Fri, 9 Sep 2005 17:43:58 +0100 [thread overview]
Message-ID: <20050909164358.GP9623@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4321B5F6.4040707@lifl.fr>
On Fri, Sep 09, 2005 at 06:19:02PM +0200, Eric Piel wrote:
> 09/09/2005 06:07 PM, viro@zeniv.linux.org.uk wrote/a ??crit:
> >Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >----
> >diff -urN RC13-git8-base/drivers/acpi/blacklist.c
> >current/drivers/acpi/blacklist.c
> >--- RC13-git8-base/drivers/acpi/blacklist.c 2005-09-08
> >23:42:49.000000000 -0400
> >+++ current/drivers/acpi/blacklist.c 2005-09-09 11:28:44.000000000 -0400
> >@@ -73,7 +73,7 @@
> > {""}
> > };
> >
> >-#if CONFIG_ACPI_BLACKLIST_YEAR
> >+#ifdef CONFIG_ACPI_BLACKLIST_YEAR
> >
> > static int __init blacklist_by_year(void)
> > {
>
> Are you sure about this? IIRC, CONFIG_ACPI_BLACKLIST_YEAR is defined to
> 0 when it should not be blacklisted. In drivers/acpi/Kconfig :
> Enter 0 to disable this mechanism and allow ACPI to
> run by default no matter what the year. (default)
Hmm.... Oh, lovely - so we have that non-zero if set, 0 if it's i386 or
amd64 and not set and not defined if it's ia64 and not set.
Sigh... It should be left as #if, of course, but I suspect that cleaner way to
deal with that would be (in Kconfig)
config ACPI_BLACKLIST_YEAR
int "Disable ACPI for systems before Jan 1st this year" if X86
default 0
Roman?
next prev parent reply other threads:[~2005-09-09 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 16:07 [PATCH] bogus #if (acpi/blacklist) viro
2005-09-09 16:19 ` Eric Piel
2005-09-09 16:43 ` viro [this message]
2005-09-09 16:55 ` Roman Zippel
2005-09-09 17:31 ` viro
2005-09-15 22:05 ` Len Brown
2005-09-22 5:14 ` Randy.Dunlap
2005-09-22 5:15 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2005-09-22 5:50 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909164358.GP9623@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Eric.Piel@lifl.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox