From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
Hans Reiser <reiser@namesys.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Reiserfs developers mail-list <Reiserfs-Dev@namesys.com>,
ReiserFS List <reiserfs-list@namesys.com>
Subject: Re: List of things requested by lkml for reiser4 inclusion (to review)
Date: Fri, 9 Sep 2005 20:00:07 +0100 [thread overview]
Message-ID: <20050909190007.GA12109@infradead.org> (raw)
In-Reply-To: <20050909185740.GA11923@infradead.org>
On Fri, Sep 09, 2005 at 07:57:40PM +0100, Christoph Hellwig wrote:
> A very annoying small thing that comes to mind is the usage of
> reiser4_internal. Please remove it, all but exported symbol are
> module-private.
Oh, one other things that's totally annoying and makes reading the
code a pain are the line-length and comment style. Please wrap
lines after 80 chars and use normal
/* foobar, blagg */
or
/*
* fvsfafsfasdrfasddddddddddddddddddddd
* fdsfsfdsfsdf
* sdfsdfs
*/
comments, thanks
next prev parent reply other threads:[~2005-09-09 19:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200509091817.39726.zam@namesys.com>
2005-09-09 17:36 ` List of things requested by lkml for reiser4 inclusion (to review) Hans Reiser
2005-09-09 17:57 ` Chris Shoemaker
2005-09-09 20:42 ` Hans Reiser
2005-09-09 20:48 ` Nish Aravamudan
2005-09-09 20:49 ` Randy.Dunlap
2005-09-09 20:57 ` Chris Shoemaker
2005-09-09 18:57 ` Christoph Hellwig
2005-09-09 19:00 ` Christoph Hellwig [this message]
2005-09-09 21:21 ` Hans Reiser
2005-09-10 4:51 ` Kyle Moffett
2005-09-10 7:28 ` Paul Jackson
2005-09-09 21:41 ` Andrew Morton
2005-09-09 22:02 ` Hans Reiser
2005-09-12 18:08 ` Hans Reiser
2005-09-12 19:40 ` Horst von Brand
2005-09-10 10:14 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909190007.GA12109@infradead.org \
--to=hch@infradead.org \
--cc=Reiserfs-Dev@namesys.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@namesys.com \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox