Re: [PATCH][Bug 5132] fix sys_poll() large timeout handling

Nishanth Aravamudan
2005-09-06T21:25:24Z

On 31.08.2005 [13:01:09 -0700], Nishanth Aravamudan wrote:
> Sorry everybody, forgot the most important Cc: :)
>
> -Nish
>
> Hi Andrew,
>
> In looking at Bug 5132 and sys_poll(), I think there is a flaw in the
> current code.
>
> The @timeout parameter to sys_poll() is in milliseconds but we compare
> it to (MAX_SCHEDULE_TIMEOUT / HZ), which is jiffies/jiffies-per-sec or
> seconds. That seems blatantly broken. Also, I think we are better served
> by converting to jiffies first then comparing, as opposed to converting
> our maximum to milliseconds (or seconds, incorrectly) and comparing.
>
> Comments, suggestions for improvement?

I haven't got any responses (here or on the bug)... A silent NACK?
Anything I should change to make people happier?

Thanks,
Nish