From: Richard Henderson <rth@twiddle.net>
To: Jan Beulich <JBeulich@novell.com>
Cc: Tom Rini <trini@kernel.crashing.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386 CFI annotations
Date: Fri, 9 Sep 2005 22:58:36 -0700 [thread overview]
Message-ID: <20050910055836.GA28662@twiddle.net> (raw)
In-Reply-To: <43214D2D02000078000247B5@emea1-mh.id2.novell.com>
On Fri, Sep 09, 2005 at 08:51:57AM +0200, Jan Beulich wrote:
> >>> Tom Rini <trini@kernel.crashing.org> 08.09.05 18:13:34 >>>
> >On Thu, Sep 08, 2005 at 05:57:55PM +0200, Jan Beulich wrote:
> >
> >> >> + CFI_ADJUST_CFA_OFFSET 4;\
> >> >> + /*CFI_REL_OFFSET es, 0;*/\
> >> >> pushl %ds; \
> >> >> + CFI_ADJUST_CFA_OFFSET 4;\
> >> >> + /*CFI_REL_OFFSET ds, 0;*/\
> >> >
> >> >Adding new commented out code never wins new friends. :)
> >>
> >> I know. But how would you indicate functionality belonging there
> but
> >> just not provided by the translating utilities. If that's really a
> >> problem, then I would need to teach the respective macros to ignore
> >> certain operands.
> >
> >Not provided by binutils or ?
>
> Not provided for even by the spec; if it was just binutils missing them
> I'd have added this already.
You know this is just convention, right? And that binutils allows
you to put any column numbers you like? So all you have to do it
match whatever debugger you're planning to use. Make something up.
r~
next prev parent reply other threads:[~2005-09-10 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 15:10 [PATCH] i386 CFI annotations Jan Beulich
2005-09-08 15:46 ` Tom Rini
[not found] ` <43207BA30200007800024502@emea1-mh.id2.novell.com>
[not found] ` <20050908161334.GP3966@smtp.west.cox.net>
2005-09-09 6:51 ` Jan Beulich
2005-09-10 5:58 ` Richard Henderson [this message]
2005-09-12 7:04 ` Jan Beulich
2005-09-12 7:49 ` Richard Henderson
2005-09-12 13:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050910055836.GA28662@twiddle.net \
--to=rth@twiddle.net \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox