public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: NUMA mempolicy /proc code in mainline shouldn't have been merged
Date: Sat, 10 Sep 2005 11:20:18 +0200	[thread overview]
Message-ID: <200509101120.19236.ak@suse.de> (raw)

Hi,

Just noticed the ugly SGI /proc/*/numa_maps code got merged.  I argued
several times against it and I very deliberately didn't include
a similar facility when I wrote the NUMA policy code because it's a bad
idea.


- it's a lot of ugly code.
- it's basically only a debugging hack right now
- it presents lots of kernel internal information and mempolicy
internals (like how many people have a page mapped) etc.
to userland that shouldn't be exposed to this.
- the format is very complicated and the chance of bug free
userland parsers of this is near zero.
- there is no demonstrated application that needs it
(there was a theoretical usecase where it might be needed,
but there were better solutions proposed for this) 


Can the patch please be removed? 

Thanks,

-Andi

             reply	other threads:[~2005-09-10  9:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-10  9:20 Andi Kleen [this message]
2005-09-10  9:33 ` NUMA mempolicy /proc code in mainline shouldn't have been merged Andrew Morton
2005-09-10 16:29   ` Christoph Lameter
2005-09-11  0:59     ` Andrew Morton
2005-09-11  2:46       ` Christoph Lameter
2005-09-11  6:51         ` Andrew Morton
2005-09-11  7:11           ` Andi Kleen
2005-09-19 17:11             ` Christoph Lameter
2005-09-19 19:40               ` Andi Kleen
2005-09-19 21:32                 ` Christoph Lameter
2005-09-19 21:56                   ` Andi Kleen
2005-09-19 22:48                     ` Andrew Morton
2005-09-19 23:13                       ` Christoph Lameter
2005-09-25  1:45                         ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200509101120.19236.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox