Re: NUMA mempolicy /proc code in mainline shouldn't have been merged

Andi Kleen
2005-09-11T07:11:45Z

On Sunday 11 September 2005 08:51, Andrew Morton wrote:

> Certainly I can see value in that. How can a developer test his
> code without any form of runtime feedback?

There are already several ways to do that: first the counters output
by numastat (local_node, other_node, interleave_hit etc.), which tells you
exactly how the allocation strategy ended up. And a process can find out
on which node a specific page is using get_mempolicy()

If you really want to know what's going on you can use performance counters
of the machine to tell you the amount of cross node traffic
(e.g. see numamon in the numactl source tree as an example)

I don't think the /proc information gives additional information
to the programmers. Externally you shouldn't know about the
individual addresses anyways.

All it does is to open the flood gates of external mempolicy management, which
is wrong.

> It's easy to parse and it is extensible. It needs documenting though.

Extensible yes, but I have my doubts on easy to parse. User processes
very likely will get it wrong like they traditionally did with anything
more complicated in /proc. /proc/*/maps has been a similar disaster too.

-Andi