From: "John W. Linville" <linville@tuxdriver.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Greg KH <gregkh@suse.de>,
davej@codemonkey.org.uk, arjan@infradead.org,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [GIT PATCH] More PCI patches for 2.6.13
Date: Sat, 10 Sep 2005 14:33:04 -0400 [thread overview]
Message-ID: <20050910183302.GA6311@tuxdriver.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0509091613310.3051@g5.osdl.org>
On Fri, Sep 09, 2005 at 04:22:25PM -0700, Linus Torvalds wrote:
> the return value of "pci_enable_wake()" for example. There's really no
> real reason to ever care, as far as I can tell - if it fails, there's
> nothing you can really do about it anyway.
>
> Also, in general, the fact is that things like "pci_set_power_state()"
> might fail in _theory_, but we just don't care. A driver that doesn't
But, aren't these arguments for changing the functions to return void?
If there is never any point in checking the results, then why have
results at all?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-09-10 18:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 22:07 [GIT PATCH] More PCI patches for 2.6.13 Greg KH
2005-09-09 22:37 ` Linus Torvalds
2005-09-09 22:54 ` Greg KH
2005-09-09 23:22 ` Linus Torvalds
2005-09-09 23:28 ` Linus Torvalds
2005-09-09 23:36 ` Andrew Morton
2005-09-10 0:22 ` Linus Torvalds
2005-09-10 1:27 ` Jeff Garzik
2005-09-10 18:33 ` John W. Linville [this message]
2005-09-10 18:53 ` Linus Torvalds
2005-09-11 11:33 ` Pavel Machek
2005-09-10 10:05 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2005-09-10 21:07 Alan Stern
2005-09-10 21:12 ` Linus Torvalds
2005-09-10 21:58 ` Jeff Garzik
2005-09-10 22:31 ` Andrew Morton
2005-09-10 22:53 ` Linus Torvalds
2005-09-10 23:44 ` Jeff Garzik
2005-09-11 0:02 ` Linus Torvalds
2005-09-11 0:17 ` Jeff Garzik
2005-09-11 0:27 ` Linus Torvalds
2005-09-10 23:02 ` Pavel Machek
2005-09-11 11:38 ` Pavel Machek
2005-09-10 22:32 ` Alistair John Strachan
2005-09-10 23:47 ` Jeff Garzik
2005-09-11 6:47 ` David Woodhouse
2005-09-11 4:41 ` Greg KH
2005-09-11 6:47 ` Alistair John Strachan
2005-09-11 2:34 Gabriel A. Devenyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050910183302.GA6311@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=davej@codemonkey.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox