From: "Gabriel A. Devenyi" <ace@staticwave.ca>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [GIT PATCH] More PCI patches for 2.6.13
Date: Sat, 10 Sep 2005 22:34:28 -0400 [thread overview]
Message-ID: <200509102234.28659.ace@staticwave.ca> (raw)
Hi Andrew,
I noticed your mail about this bug in a discussion on PCI patches for 2.6.13, I emailed the list with some info
about this bug, so here it is again, perhaps this can clear up what the problem is, sorry I don't have a patch,
I don't understand the kernel well enough for that.
drivers/pci/probe.c: In function `pci_read_bases':
drivers/pci/probe.c:166: warning: large integer implicitly truncated to unsigned type
drivers/pci/probe.c:216: warning: large integer implicitly truncated to unsigned type
I've tracked this down to pci_size, and two #define's in include/linux/pci.h
#define PCI_BASE_ADDRESS_MEM_MASK (~0x0fUL)
#define PCI_ROM_ADDRESS_MASK (~0x7ffUL)
pci_size expects 3 u32 arguments,but from what I can tell, on 64 bit arch's the two above
defines expand to 64bit values, and are truncated when being passed.
I'm not sure how to go about fixing this, if pci_size should accept a u64 or if the defines should
be changed. Is this bug dangerous? What should be done to fix it?
--
Gabriel A. Devenyi
ace@staticwave.ca
next reply other threads:[~2005-09-11 2:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-11 2:34 Gabriel A. Devenyi [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-10 21:07 [GIT PATCH] More PCI patches for 2.6.13 Alan Stern
2005-09-10 21:12 ` Linus Torvalds
2005-09-10 21:58 ` Jeff Garzik
2005-09-10 22:31 ` Andrew Morton
2005-09-10 22:53 ` Linus Torvalds
2005-09-10 23:44 ` Jeff Garzik
2005-09-11 0:02 ` Linus Torvalds
2005-09-11 0:17 ` Jeff Garzik
2005-09-11 0:27 ` Linus Torvalds
2005-09-10 23:02 ` Pavel Machek
2005-09-11 11:38 ` Pavel Machek
2005-09-10 22:32 ` Alistair John Strachan
2005-09-10 23:47 ` Jeff Garzik
2005-09-11 6:47 ` David Woodhouse
2005-09-11 4:41 ` Greg KH
2005-09-11 6:47 ` Alistair John Strachan
2005-09-09 22:07 Greg KH
2005-09-09 22:37 ` Linus Torvalds
2005-09-09 22:54 ` Greg KH
2005-09-09 23:22 ` Linus Torvalds
2005-09-09 23:28 ` Linus Torvalds
2005-09-09 23:36 ` Andrew Morton
2005-09-10 0:22 ` Linus Torvalds
2005-09-10 1:27 ` Jeff Garzik
2005-09-10 18:33 ` John W. Linville
2005-09-10 18:53 ` Linus Torvalds
2005-09-11 11:33 ` Pavel Machek
2005-09-10 10:05 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509102234.28659.ace@staticwave.ca \
--to=ace@staticwave.ca \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox