Re: [GIT PATCH] More PCI patches for 2.6.13

[Greg KH <greg@kroah.com>]

On Sat, Sep 10, 2005 at 11:32:54PM +0100, Alistair John Strachan wrote:
> On Saturday 10 September 2005 22:58, Jeff Garzik wrote:
> > Linus Torvalds wrote:
> > > Case closed.
> > >
> > > Bogus warnings are a _bad_ thing. They cause people to write buggy code.
> > >
> > > That drivers/pci/pci.c code should be simplified to not look at the error
> > > return from pci_set_power_state() at all. Special-casing EIO is just
> > > another bug waiting to happen.
> >
> > As a tangent, the 'foo is deprecated' warnings for pm_register() and
> > inter_module_register() annoy me, primarily because they never seem to
> > go away.
> >
> > The only user of inter_module_xxx is CONFIG_MTD -- thus the deprecated
> > warning is useless to 90% of us, who will never use MTD.  As for
> > pm_register(), there are tons of users remaining.  As such, for the
> > forseeable future, we will continue to see pm_register() warnings and
> > ignore them -- thus they are nothing but useless build noise.
> >
> > I've attached a patch, just tested, which addresses inter_module_xxx by
> > making its build conditional on the last remaining user.  This solves
> > the deprecated warning problem for most of us, and makes the kernel
> > smaller for most of us, at the same time.
> 
> Though external modules using these functions will be hung out to dry.

External modules are always hung out to dry.  Seriously, you don't have
code using those functions, do you?  If so, it's not like you haven't
been warned...

thanks,

greg k-h