public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Lameter <clameter@engr.sgi.com>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: NUMA mempolicy /proc code in mainline shouldn't have been merged
Date: Sun, 11 Sep 2005 09:11:20 +0200	[thread overview]
Message-ID: <200509110911.22212.ak@suse.de> (raw)
In-Reply-To: <20050910235139.4a8865c2.akpm@osdl.org>

On Sunday 11 September 2005 08:51, Andrew Morton wrote:

> Certainly I can see value in that.  How can a developer test his
> code without any form of runtime feedback?

There are already several ways to do that: first the counters output
by numastat (local_node, other_node, interleave_hit etc.), which tells you 
exactly how the allocation strategy ended up. And a process can find out
on which node a specific page is using get_mempolicy()

If you really want to know what's going on you can use performance counters
of the machine to tell you the amount of cross node traffic
(e.g. see numamon in the numactl source tree as an example) 

I don't think the /proc information gives additional information
to the programmers. Externally you shouldn't know about the 
individual addresses anyways.

All it does is to open the flood gates of external mempolicy management, which 
is wrong.

> It's easy to parse and it is extensible.  It needs documenting though.

Extensible yes, but I have my doubts on easy to parse. User processes
very likely will get it wrong like they traditionally did with anything
more complicated in /proc. /proc/*/maps has been a similar disaster too.

-Andi

  reply	other threads:[~2005-09-11  7:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-10  9:20 NUMA mempolicy /proc code in mainline shouldn't have been merged Andi Kleen
2005-09-10  9:33 ` Andrew Morton
2005-09-10 16:29   ` Christoph Lameter
2005-09-11  0:59     ` Andrew Morton
2005-09-11  2:46       ` Christoph Lameter
2005-09-11  6:51         ` Andrew Morton
2005-09-11  7:11           ` Andi Kleen [this message]
2005-09-19 17:11             ` Christoph Lameter
2005-09-19 19:40               ` Andi Kleen
2005-09-19 21:32                 ` Christoph Lameter
2005-09-19 21:56                   ` Andi Kleen
2005-09-19 22:48                     ` Andrew Morton
2005-09-19 23:13                       ` Christoph Lameter
2005-09-25  1:45                         ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200509110911.22212.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox