Re: [GIT PATCH] More PCI patches for 2.6.13

[Pavel Machek <pavel@suse.cz>]

Hi!

> >  As for pm_register(), there are tons of users remaining.
> 
> Well it would kinda help if people knew what to _do_ about pm_register(). 
> Documentation/pm.txt cheerfully tells everyone how to use it in new code
> and the comment over the pm_register() implementation doesn't say that it's
> deprecated and doesn't tell people what to replace it with.

Well, Doc*/pm.txt seems to say this is "not to use"

Driver Interface -- OBSOLETE, DO NOT USE!
----------------*************************

anyway, if you want a comment "what to do with it", here it is:

---

Tell people not to use pm_register().

Signed-off-by: Pavel Machek <pavel@suse.cz>

diff --git a/Documentation/pm.txt b/Documentation/pm.txt
--- a/Documentation/pm.txt
+++ b/Documentation/pm.txt
@@ -38,6 +38,12 @@ system the associated daemon will exit g
 
 Driver Interface -- OBSOLETE, DO NOT USE!
 ----------------*************************
+
+Note: pm_register(), pm_access(), pm_dev_idle() and friends are
+obsolete. Please do not use them. Instead you should properly hook
+your driver into the driver model, and use its suspend()/resume()
+callbacks to do this kind of stuff.
+
 If you are writing a new driver or maintaining an old driver, it
 should include power management support.  Without power management
 support, a single driver may prevent a system with power management


-- 
if you have sharp zaurus hardware you don't need... you know my address