public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/char/isicom old api rewritten (round 3)
Date: Sun, 11 Sep 2005 21:58:34 -0700	[thread overview]
Message-ID: <20050912045834.GA18780@kroah.com> (raw)
In-Reply-To: <200509112311.j8BNB0sA016447@wscnet.wsc.cz>

On Mon, Sep 12, 2005 at 01:11:00AM +0200, Jiri Slaby wrote:
> > > >40k isn't large - please include such patches in the email.
> > > >
> > > Thank you, Andrew, for your reply and hints, you sent.
> > Did everything get addressed?
> Maybe not, if you still want it in e-mail as plaintext, grr.
> 
> > Then send the patch, cc'ed to the mailing list as per
> > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.
> Oops, I read only SubmittingPatches. So this file should be changed in point 7
> (that not everybody wants URLs).
> 
> 
> 
> This patch removes old api in pci probing and replaces it with new. Firmware
> loading added.

You do a lot of different things in this patch (whitespace changes, line
wrapps, etc.)  Try a few patches in order (coding style issues, then pci
api, then firmware, etc.)

thanks,

greg k-h

  reply	other threads:[~2005-09-12  4:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-10 23:19 [PATCH -mm 1/2] drivers/char/isicom old api rewritten Jiri Slaby
2005-09-10 23:21 ` [PATCH -mm 2/2] drivers/char/isicom whitespace cleanup Jiri Slaby
2005-09-10 23:53 ` [PATCH -mm 1/2] drivers/char/isicom old api rewritten Andrew Morton
2005-09-11 22:04   ` [PATCH] drivers/char/isicom old api rewritten (round 2) Jiri Slaby
2005-09-11 22:20     ` Andrew Morton
2005-09-11 23:11       ` [PATCH] drivers/char/isicom old api rewritten (round 3) Jiri Slaby
2005-09-12  4:58         ` Greg KH [this message]
2005-09-12 12:58           ` [PATCH] drivers/char/isicom whitespace cleanup Jiri Slaby
2005-09-13 16:49           ` [PATCH 0/5] isicom char driver to 2.6 api Jiri Slaby
2005-09-13 16:52             ` [PATCH 2/5] isicom: types Jiri Slaby
2005-09-13 16:52             ` [PATCH 3/5] isicom: pci probing Jiri Slaby
2005-09-13 17:21               ` Greg KH
2005-09-14  0:10                 ` [PATCH 0/6] isicom char driver rewritten to 2.6 api Jiri Slaby
2005-09-14  0:12                   ` [PATCH 1/6] isicom: Whitespace cleanup Jiri Slaby
2005-09-14  0:12                   ` [PATCH 2/6] isicom: Type conversion and variables deletion Jiri Slaby
2005-09-14  0:12                   ` [PATCH 3/6] isicom: Others little changes Jiri Slaby
2005-09-14  0:13                   ` [PATCH 4/6] isicom: Pci probing added Jiri Slaby
2005-09-14  0:13                   ` [PATCH 5/6] isicom: Firmware loading Jiri Slaby
2005-09-14  0:13                   ` [PATCH 6/6] isicom: More whitespaces and coding style Jiri Slaby
2005-09-13 16:52             ` [PATCH 4/5] isicom: firmware Jiri Slaby
2005-09-13 16:52             ` [PATCH 1/5] isicom: whitespace Jiri Slaby
2005-09-13 16:52             ` [PATCH 5/5] isicom: more whitespace Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050912045834.GA18780@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox