From: "John W. Linville" <linville@tuxdriver.com>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
tony.luck@intel.com
Subject: Re: [patch 2.6.13] ia64: add EXPORT_SYMBOL_GPL for ia64_max_cacheline_size
Date: Mon, 12 Sep 2005 20:06:13 -0400 [thread overview]
Message-ID: <20050913000611.GI19644@tuxdriver.com> (raw)
In-Reply-To: <20050912192524.GA14360@infradead.org>
On Mon, Sep 12, 2005 at 08:25:24PM +0100, Christoph Hellwig wrote:
> On Mon, Sep 12, 2005 at 10:48:52AM -0400, John W. Linville wrote:
> > The implementation of dma_get_cache_alignment for ia64 makes reference
> > to ia64_max_cacheline_size inside of a static inline. For this to
> > work for modules, this needs to be EXPORT_SYMBOL{,_GPL}.
>
> This is not supposed to be a _GPL api. best just move
> dma_get_cache_alignment out of line.
You are thinking of something like the x86_64 implementation?
That seems reasonable to me. Patch to follow...
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-09-13 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-12 14:48 [patch 2.6.13] ia64: add EXPORT_SYMBOL_GPL for ia64_max_cacheline_size John W. Linville
2005-09-12 19:25 ` Christoph Hellwig
2005-09-13 0:06 ` John W. Linville [this message]
2005-09-13 0:14 ` [patch 2.6.13] ia64: re-implement dma_get_cache_alignment to avoid EXPORT_SYMBOL John W. Linville
2005-09-13 9:24 ` Christoph Hellwig
2005-09-13 12:25 ` Lion Vollnhals
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050913000611.GI19644@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox