From: Matthew Garrett <mjg59@srcf.ucam.org>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Subject: [PATCH] - allow multiple ac97 quirks for one piece of hardware
Date: Tue, 13 Sep 2005 15:52:47 +0100 [thread overview]
Message-ID: <20050913145247.GA8422@srcf.ucam.org> (raw)
snd_ac97_tune_hardware currently exits after applying a single ac97
quirk. There are bits of hardware (current HPs, for instance) that
probably want two - MUTE_LED and HP_ONLY. The following trivial patch
only exits if a quirk fails to apply. I'll send patches adding the
quirks when I've made sure they work as expected on these machines.
--- sound/pci/ac97/ac97_codec.c.orig 2005-09-13 15:45:35.000000000 +0100
+++ linux/sound/pci/ac97/ac97_codec.c 2005-09-13 15:46:05.000000000 +0100
@@ -2551,9 +2551,10 @@ int snd_ac97_tune_hardware(ac97_t *ac97,
continue;
snd_printdd("ac97 quirk for %s (%04x:%04x)\n", quirk->name, ac97->subsystem_vendor, ac97->subsystem_device);
result = apply_quirk(ac97, quirk->type);
- if (result < 0)
+ if (result < 0) {
snd_printk(KERN_ERR "applying quirk type %d for %s failed (%d)\n", quirk->type, quirk->name, result);
- return result;
+ return result;
+ }
}
}
return 0;
--
Matthew Garrett | mjg59@srcf.ucam.org
next reply other threads:[~2005-09-13 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 14:52 Matthew Garrett [this message]
2005-09-14 10:27 ` [Alsa-devel] [PATCH] - allow multiple ac97 quirks for one piece of hardware Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050913145247.GA8422@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox