From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: joern@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Permanently fix kernel configuration include mess (was: Missing #include <config.h>)
Date: Wed, 14 Sep 2005 09:48:36 +0100 [thread overview]
Message-ID: <20050914094835.A30672@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050914013944.5ee4efa7.akpm@osdl.org>; from akpm@osdl.org on Wed, Sep 14, 2005 at 01:39:44AM -0700
On Wed, Sep 14, 2005 at 01:39:44AM -0700, Andrew Morton wrote:
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> >
> > LINUXINCLUDE := -Iinclude \
> > - $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include)
> > + $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> > + -imacros include/linux/autoconf.h
>
> This means that over time the kernel will fail to compile correctly without
> `-imacros include/linux/autoconf.h'.
>
> That's OK for the kernel, but not for out-of-tree stuff. Those drivers
> will need to add the new gcc commandline option too.
>
> Not that I'm saying it's a terrible thing. It's just a thing.
Well I don't really understand all the kbuild complexities, so I just
did a "what works for me in the setups I have" patch. Maybe someone
who properly understands the kbuild complexity should have a look.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-09-14 8:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 13:56 Missing #include <config.h> Jörn Engel
2005-09-13 14:08 ` Russell King
2005-09-13 14:12 ` Christoph Hellwig
2005-09-13 17:57 ` Geert Uytterhoeven
2005-09-13 18:02 ` Russell King
2005-09-13 14:50 ` [PATCH] Permanently fix kernel configuration include mess (was: Missing #include <config.h>) Russell King
2005-09-13 16:59 ` Joern Engel
2005-09-13 18:04 ` Russell King
2005-09-13 19:10 ` [PATCH] Permanently fix kernel configuration include mess Brian Gerst
2005-09-13 19:33 ` Josh Boyer
2005-09-13 20:10 ` Alexey Dobriyan
2005-09-14 8:39 ` [PATCH] Permanently fix kernel configuration include mess (was: Missing #include <config.h>) Andrew Morton
2005-09-14 8:48 ` Russell King [this message]
2005-09-14 13:48 ` Sergey Vlasov
2005-09-14 14:02 ` Christoph Hellwig
2005-09-14 17:04 ` Sam Ravnborg
2005-09-13 14:12 ` Missing #include <config.h> Josh Boyer
2005-09-13 14:28 ` Russell King
2005-09-13 14:40 ` Josh Boyer
2005-09-13 16:22 ` Doug Maxey
2005-09-13 17:55 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050914094835.A30672@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=joern@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox