public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Collier <Ian.Collier@comlab.ox.ac.uk>
To: linux-kernel@vger.kernel.org
Subject: 2.6.13: More on drivers/block/loop.c
Date: Wed, 14 Sep 2005 13:51:18 +0100	[thread overview]
Message-ID: <20050914135118.A25087@pixie.comlab> (raw)
In-Reply-To: <20050909132725.C23462@pixie.comlab>; from Ian.Collier@comlab.ox.ac.uk on Fri, Sep 09, 2005 at 01:27:26PM +0100

Vanilla 2.6.13 doesn't crash.

However, unpack a fresh copy of 2.6.13, edit include/linux/loop.h to
change LO_KEY_SIZE from 32 to 1844, and *boom*.  [Don't ask me why
1844... that's just what PPDD wants.]

It's crashing somewhere in loop_set_status_old, probably during the
call to copy_from_user, but the crash messages aren't that helpful as
they are different each time, often seem to happen during an interrupt,
and usually contain pages of recursive calls to do_page_fault and
error_code.

The loop_set_status_old function has two local variables, each of which
is now 1812 bytes longer than it was, and I'm wondering if it's a stack
overflow problem.  How much stack is a kernel function allowed to use,
anyway?

Replacing these variables with kmalloc'd pointers seems to stop the crashes
anyway, so I'll pass that tip on to the PPDD folks.

imc

  parent reply	other threads:[~2005-09-14 12:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09 12:27 2.6.13: loop ioctl crashes Ian Collier
2005-09-09 12:32 ` linux-os (Dick Johnson)
2005-09-09 13:38   ` Ian Collier
2005-09-09 14:41     ` linux-os (Dick Johnson)
2005-09-09 14:59       ` linux-os (Dick Johnson)
2005-09-09 15:42       ` Ian Collier
2005-09-14 12:51 ` Ian Collier [this message]
2005-09-14 13:12   ` 2.6.13: More on drivers/block/loop.c Anton Altaparmakov
2005-09-14 15:38 ` loop: auto-load crypto module [PATCH] Ian Collier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914135118.A25087@pixie.comlab \
    --to=ian.collier@comlab.ox.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox