From: Greg KH <greg@kroah.com>
To: Robert Love <rml@novell.com>
Cc: Mr Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] hdaps driver update.
Date: Wed, 14 Sep 2005 09:05:27 -0700 [thread overview]
Message-ID: <20050914160527.GA22352@kroah.com> (raw)
In-Reply-To: <1126713453.5738.7.camel@molly>
On Wed, Sep 14, 2005 at 11:57:33AM -0400, Robert Love wrote:
> +/* dummy release function -- everything is static, nothing to free */
> +static void hdaps_dummy_release(struct device *dev) { }
Woah, no, this is not ok. Please see my objections to this the zillion
other times people have tried to do this...
Why is this static? Shouldn't it be dynamic and then your release would
be able to free the memory?
> static struct device_driver hdaps_driver = {
> .name = "hdaps",
> .bus = &platform_bus_type,
> - .owner = THIS_MODULE,
> .probe = hdaps_probe,
> .resume = hdaps_resume
> };
Why delete that? You just lost your symlink in sysfs then :(
thanks,
greg k-h
next prev parent reply other threads:[~2005-09-14 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 15:57 [patch] hdaps driver update Robert Love
2005-09-14 16:05 ` Greg KH [this message]
2005-09-14 16:09 ` Robert Love
2005-09-14 16:16 ` Greg KH
2005-09-14 16:31 ` Robert Love
2005-09-14 17:14 ` Dmitry Torokhov
2005-09-14 17:55 ` Robert Love
2005-09-14 17:38 ` Greg KH
2005-09-14 17:28 ` Dmitry Torokhov
2005-09-14 17:39 ` Greg KH
2005-09-14 18:19 ` [patch] hdaps driver update, updated Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050914160527.GA22352@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox