public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: akpm@osdl.org, rbh00@utsglobal.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/7] s390: 3270 fullscreen view.
Date: Wed, 14 Sep 2005 17:10:22 +0100	[thread overview]
Message-ID: <20050914161022.GA4230@infradead.org> (raw)
In-Reply-To: <20050914155345.GA11478@skybase.boeblingen.de.ibm.com>

On Wed, Sep 14, 2005 at 05:53:45PM +0200, Martin Schwidefsky wrote:
> [patch 2/7] s390: 3270 fullscreen view.
> 
> From: Richard Hitt <rbh00@utsglobal.com>
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
> 
> Fix fullscreen view of the 3270 device driver.
> 
> Signed-off-by: Richard Hitt <rbh00@utsglobal.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> 
> diffstat:
>  arch/s390/kernel/compat_ioctl.c |    9 +
>  drivers/s390/char/con3270.c     |    7 -
>  drivers/s390/char/fs3270.c      |  234 +++++++++++++++++++++++++++++++++-------
>  drivers/s390/char/raw3270.c     |  100 +++++++++++++++--
>  drivers/s390/char/raw3270.h     |    7 +
>  drivers/s390/char/tty3270.c     |   27 ++--
>  6 files changed, 315 insertions(+), 69 deletions(-)
> 
> diff -urpN linux-2.6/arch/s390/kernel/compat_ioctl.c linux-2.6-patched/arch/s390/kernel/compat_ioctl.c
> --- linux-2.6/arch/s390/kernel/compat_ioctl.c	2005-08-29 01:41:01.000000000 +0200
> +++ linux-2.6-patched/arch/s390/kernel/compat_ioctl.c	2005-09-14 16:48:15.000000000 +0200
> @@ -18,6 +18,8 @@
>  #include <asm/dasd.h>
>  #include <asm/cmb.h>
>  #include <asm/tape390.h>
> +#include <asm/ccwdev.h>
> +#include "../../../drivers/s390/char/raw3270.h"

Umm, no.  Please implement a compat_ioctl methods for the driver instead.
a volunteer ;-)


  reply	other threads:[~2005-09-14 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-14 15:53 [patch 2/7] s390: 3270 fullscreen view Martin Schwidefsky
2005-09-14 16:10 ` Christoph Hellwig [this message]
2005-09-14 17:31   ` Martin Schwidefsky
2005-09-15 17:24     ` Greg KH
2005-09-16  8:07       ` Martin Schwidefsky
2005-09-16 23:20         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914161022.GA4230@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rbh00@utsglobal.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox