Re: Missing #include <config.h>

Geert Uytterhoeven
2005-09-13T17:56:13Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=UTF-8, Size: 1137 bytes --]

On Tue, 13 Sep 2005, [iso-8859-1] Jörn Engel wrote:
> After spending some hours last night and this morning hunting a bug,
> I've found that a different include order made a difference. Some
> files don't work correctly, unless config.h is included before.
>
> Here is a very stupid bug checker for the problem class:
> $ rgrep CONFIG include/ | cut -d: -f1 | sort -u > g1
> $ rgrep CONFIG include/ | cut -d: -f1 | sort -u | xargs grep "config.h" | cut -d: -f1 | sort -u > g2
> $ diff -u g1 g2 | grep ^- > g3
>
> Result is quite a long list for 2.6.13. include/config/* are false
> positives, ok. But what should we do about the rest?

> -include/asm-m68k/amigayle.h
> -include/asm-m68k/amipcmcia.h
> -include/asm-m68k/bvme6000hw.h
> -include/asm-m68k/ioctls.h
> -include/asm-m68k/mvme16xhw.h

These are false positives as well.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds