From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>
Date: Thu, 15 Sep 2005 01:46:01 -0500 [thread overview]
Message-ID: <20050915064943.853864000.dtor_core@ameritech.net> (raw)
In-Reply-To: 20050915064552.836273000.dtor_core@ameritech.net
Greg KH <gregkh@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>,
Vojtech Pavlik <vojtech@suse.cz>,
Hannes Reinecke <hare@suse.de>
Subject: [patch 09/28] Input: convert net/bluetooth to dynamic input_dev allocation
Content-Disposition: inline; filename=input-dynalloc-bluetooth.patch
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Input: convert net/bluetooth to dynamic input_dev allocation
This is required for input_dev sysfs integration
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
net/bluetooth/hidp/core.c | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
Index: work/net/bluetooth/hidp/core.c
===================================================================
--- work.orig/net/bluetooth/hidp/core.c
+++ work/net/bluetooth/hidp/core.c
@@ -520,7 +520,7 @@ static int hidp_session(void *arg)
if (session->input) {
input_unregister_device(session->input);
- kfree(session->input);
+ session->input = NULL;
}
up_write(&hidp_session_sem);
@@ -536,6 +536,8 @@ static inline void hidp_setup_input(stru
input->private = session;
+ input->name = "Bluetooth HID Boot Protocol Device";
+
input->id.bustype = BUS_BLUETOOTH;
input->id.vendor = req->vendor;
input->id.product = req->product;
@@ -582,16 +584,15 @@ int hidp_add_connection(struct hidp_conn
return -ENOTUNIQ;
session = kmalloc(sizeof(struct hidp_session), GFP_KERNEL);
- if (!session)
+ if (!session)
return -ENOMEM;
memset(session, 0, sizeof(struct hidp_session));
- session->input = kmalloc(sizeof(struct input_dev), GFP_KERNEL);
+ session->input = input_allocate_device();
if (!session->input) {
kfree(session);
return -ENOMEM;
}
- memset(session->input, 0, sizeof(struct input_dev));
down_write(&hidp_session_sem);
@@ -651,8 +652,10 @@ unlink:
__hidp_unlink_session(session);
- if (session->input)
+ if (session->input) {
input_unregister_device(session->input);
+ session->input = NULL; /* don't try to free it here */
+ }
failed:
up_write(&hidp_session_sem);
next prev parent reply other threads:[~2005-09-15 6:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 6:45 Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:45 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov [this message]
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
2005-09-15 15:30 ` subject goes here? Chris White
2005-09-15 7:05 ` Dmitry Torokhov
2005-09-15 6:46 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050915064943.853864000.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox