From: Pavel Machek <pavel@suse.cz>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
Allan Graves <allan.graves@gmail.com>
Subject: Re: [PATCH 1/10] UML - _switch_to code consolidation
Date: Thu, 15 Sep 2005 11:58:28 +0200 [thread overview]
Message-ID: <20050915095828.GE7880@elf.ucw.cz> (raw)
In-Reply-To: <200509142155.j8ELtm5c012124@ccure.user-mode-linux.org>
Hi!
> This patch moves code that is in both switch_to_tt and
> switch_to_skas to the top level _switch_to function, keeping us from
> duplicating code. It is required for the stack trace patch to work
> properly.
>
> Signed-off-by: Allan Graves <allan.graves@gmail.com>
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>
> Index: linux-2.6.13/arch/um/kernel/process_kern.c
> ===================================================================
> --- linux-2.6.13.orig/arch/um/kernel/process_kern.c 2005-09-13 16:04:11.000000000 -0400
> +++ linux-2.6.13/arch/um/kernel/process_kern.c 2005-09-13 16:08:18.000000000 -0400
> @@ -113,8 +113,16 @@
>
> void *_switch_to(void *prev, void *next, void *last)
> {
> - return(CHOOSE_MODE(switch_to_tt(prev, next),
> - switch_to_skas(prev, next)));
> + struct task_struct *from = prev;
> + struct task_struct *to= next;
> +
> + to->thread.prev_sched = from;
> + set_current(to);
> +
> + CHOOSE_MODE_PROC(switch_to_tt, switch_to_skas, prev, next);
> +
> + return(current->thread.prev_sched);
> +
> }
I sense a whitespace damage here.
Pavel
--
if you have sharp zaurus hardware you don't need... you know my address
next prev parent reply other threads:[~2005-09-15 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 21:55 [PATCH 1/10] UML - _switch_to code consolidation Jeff Dike
2005-09-15 5:30 ` Andrew Morton
2005-09-15 19:21 ` Jeff Dike
2005-09-15 9:58 ` Pavel Machek [this message]
2005-09-16 18:55 ` [uml-devel] " Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050915095828.GE7880@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=allan.graves@gmail.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox