From: Andrea Arcangeli <andrea@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Hugh Dickins <hugh@veritas.com>, Nick Piggin <npiggin@novell.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Roland McGrath <roland@redhat.com>
Subject: Re: ptrace can't be transparent on readonly MAP_SHARED
Date: Thu, 15 Sep 2005 17:47:02 +0200 [thread overview]
Message-ID: <20050915154702.GA4122@opteron.random> (raw)
In-Reply-To: <Pine.LNX.4.58.0509150805150.26803@g5.osdl.org>
On Thu, Sep 15, 2005 at 08:12:59AM -0700, Linus Torvalds wrote:
> have a PROT_READONLY/PROT_NONE area that is visible from the debugger, but
> continues to cause SIGSEGV's if the user process itself tries to access
> it. To me, that's good.
Continue to cause sigsegv yes, but on the wrong page, when it will read
the page it can contain different data compared to what is on
disk/pagecache.
> There would have to be some real advantage to _not_ doing what we're doing
> now. And I don't see an advantage.
The advantage is a faster fast path and less special cases to keep in
mind.
> The real complexity is not "maybe_mkwrite()", which is trivial. The real
It is trivial yes, but for it to work without deadlocks, it requires
non-trivial changes to the page fault handler and get_user_pages.
I guess this is mostly a matter of taste, but my taste is about keeping
it simple and fast (though the difference is certainly not measurable).
Thanks.
next prev parent reply other threads:[~2005-09-15 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 21:24 ptrace can't be transparent on readonly MAP_SHARED Andrea Arcangeli
2005-09-15 4:05 ` Nick Piggin
2005-09-15 13:18 ` Hugh Dickins
2005-09-15 15:12 ` Linus Torvalds
2005-09-15 15:47 ` Andrea Arcangeli [this message]
2005-09-15 16:13 ` Linus Torvalds
2005-09-15 16:23 ` Andrea Arcangeli
2005-09-15 16:34 ` Linus Torvalds
2005-09-15 16:51 ` Andrea Arcangeli
2005-09-15 17:52 ` Linus Torvalds
2005-09-15 18:09 ` Andrea Arcangeli
2005-09-15 21:09 ` Daniel Jacobowitz
2005-09-15 21:58 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050915154702.GA4122@opteron.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@novell.com \
--cc=roland@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox