Re: [patch 6/7] s390: ipl device.

[Greg KH <greg@kroah.com>]

On Wed, Sep 14, 2005 at 05:55:09PM +0200, Martin Schwidefsky wrote:
> [patch 6/7] s390: ipl device.
> 
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> Export the ipl device settings to userspace via the sysfs:
>  * /sys/kernel/ipl_device

What?  Why that location?  Why not in the proper location for your
device, on your bus?

>    Contains a string in on of the following formats:
>    1) "ccw <bus_id>", or 2) "fcp <bus_id>,<wwpn>,<lun>".
>  * /sys/kernel/ipl_parameter
>    is a binary interface that exports the ipl  parameter block for
>    scsi ipl. For non-scsi ipl the ipl_paramter is irrelevant.

Again, put this in your device directory, not in /sys/kernel/


> +static ssize_t
> +ipl_device_show(struct subsystem *subsys, char *page)
> +{
> +	struct ipl_parameter_block *ipl = IPL_PARMBLOCK_START;
> +
> +	if (!IPL_DEVNO_VALID)
> +		goto type_unknown;
> +	if (!IPL_PARMBLOCK_VALID)
> +		goto type_ccw;
> +	if (ipl->hdr.header.version > IPL_MAX_SUPPORTED_VERSION)
> +		goto type_unknown;
> +	if (ipl->fcp.pbt != IPL_TYPE_FCP)
> +		goto type_unknown;
> +
> +	return sprintf(page, "fcp 0.0.%04x,0x%016llx,0x%016llx\n",
> +		       ipl->fcp.devno,
> +		       (unsigned long long) ipl->fcp.wwpn,
> +		       (unsigned long long) ipl->fcp.lun);
> + type_unknown:
> +	return sprintf(page, "unknown\n");
> + type_ccw:
> +	return sprintf(page, "ccw 0.0.%04x\n",ipl_devno);

That doesn't look like a "single value" from a single file there.  Can't
you break that up into individual files, based on what exactly is
present at the time?

thanks,

greg k-h