From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-kernel@vger.kernel.org, rmk+serial@arm.linux.org.uk
Subject: Re: [PATCH] epca iomem annotations + several missing readw()
Date: Thu, 15 Sep 2005 22:38:38 +0100 [thread overview]
Message-ID: <20050915213838.GA19626@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0509151419160.26803@g5.osdl.org>
On Thu, Sep 15, 2005 at 02:23:53PM -0700, Linus Torvalds wrote:
>
> Gaah.
>
> On Thu, 15 Sep 2005, Al Viro wrote:
> > { /* Begin post_fep_init */
> >
> > int i;
> > - unsigned char *memaddr;
> > - struct global_data *gd;
> > + unsigned char __iomem *memaddr;
> > + struct global_data __iomem *gd;
>
> Please don't use "[unsigned] char __iomem *".
Not a problem, I simply wanted to keep __iomem stuff apart from driver
cleanups.
> Why? Two reasons:
[obvious - we are in full agreement here]
> I bet the patch would look like a nice cleanup if you did that. Hint,
> hint.
OK... I'd rather do that as an incremental, to keep unrelated changes
separate, but I can merge them if you prefer it that way.
next prev parent reply other threads:[~2005-09-15 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 19:27 [PATCH] epca iomem annotations + several missing readw() Al Viro
2005-09-15 21:23 ` Linus Torvalds
2005-09-15 21:38 ` Al Viro [this message]
2005-09-15 21:53 ` Al Viro
2005-09-15 22:10 ` Russell King
2005-09-15 22:19 ` Al Viro
2005-09-15 22:27 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2005-09-09 19:23 viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050915213838.GA19626@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
--cc=torvalds@osdl.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox