Re: [linux-usb-devel] Re: Lost keyboard on Inspiron 8200 at 2.6.13

[Greg KH <greg@kroah.com>]

On Fri, Sep 16, 2005 at 03:24:32PM -0700, Pete Zaitcev wrote:
> On Fri, 16 Sep 2005 11:44:40 -0700, Greg KH <greg@kroah.com> wrote:
> > On Fri, Sep 16, 2005 at 05:00:49PM +0100, Alan Cox wrote:
> > > On Gwe, 2005-09-16 at 10:25 -0500, Dmitry Torokhov wrote:
> 
> > Only if we merge the code that does the handoff, with the same code that
> > does it in the usb core, would I feel more comfortable to enable this
> > always.  I had a patch from David Brownell to do this, but it had some
> > link errors at times, so I had to drop it :(
> 
> I see why you would want to merge them, but is it worth the trouble?

We've already divered from the original code, which was identical.
People forget to fix the other instance, when then change one of them.

> They are not identical. For one thing, early handoff installs its own
> fake interrupt handlers (Alan Cox insisted on it in the RHEL
> implementation).

The interrupt handlers aren't an issue.  It's how the handoff happens at
a hardware level that is.  I just want to make sure any changes made to
one place, make it to the other place.

thanks,

greg k-h