URB_ASYNC_UNLINK b0rkage

URB_ASYNC_UNLINK b0rkage

[Alexey Dobriyan]

Perhaps, another press release to explain breakage of allmodconfig is
needed.
------------------------------------------------------------------------
drivers/usb/host/hc_crisv10.c:	if (urb->transfer_flags & URB_ASYNC_UNLINK) {
drivers/usb/host/hc_crisv10.c:		/* If URB_ASYNC_UNLINK is set:
drivers/usb/host/hc_crisv10.c:		warn("URB_ASYNC_UNLINK set, ignoring.");
drivers/usb/misc/uss720.c:	/* rq->urb->transfer_flags |= URB_ASYNC_UNLINK; */
drivers/isdn/hisax/st5481_b.c:	b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
drivers/isdn/hisax/st5481_b.c:	b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
drivers/isdn/hisax/st5481_usb.c:	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
drivers/isdn/hisax/st5481_usb.c:	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
Documentation/usb/URB.txt:the URB_ASYNC_UNLINK flag in urb->transfer flags before calling

Re: [linux-usb-devel] URB_ASYNC_UNLINK b0rkage

[Alan Stern]

On Sun, 18 Sep 2005, Alexey Dobriyan wrote:

> Perhaps, another press release to explain breakage of allmodconfig is
> needed.
> ------------------------------------------------------------------------
> drivers/usb/host/hc_crisv10.c:	if (urb->transfer_flags & URB_ASYNC_UNLINK) {
> drivers/usb/host/hc_crisv10.c:		/* If URB_ASYNC_UNLINK is set:
> drivers/usb/host/hc_crisv10.c:		warn("URB_ASYNC_UNLINK set, ignoring.");
> drivers/usb/misc/uss720.c:	/* rq->urb->transfer_flags |= URB_ASYNC_UNLINK; */
> drivers/isdn/hisax/st5481_b.c:	b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> drivers/isdn/hisax/st5481_b.c:	b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> drivers/isdn/hisax/st5481_usb.c:	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> drivers/isdn/hisax/st5481_usb.c:	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> Documentation/usb/URB.txt:the URB_ASYNC_UNLINK flag in urb->transfer flags before calling

hc_crisv10 is long out-of-date and doesn't even build, as you saw.  Is 
anyone still using it?  It probably should be removed from the Makefile.

The line in drivers/usb/misc/uss720.c is just a comment.  Presumably it 
can be taken out with no harm done.

In my kernel tree, the st5481 source files don't include the lines you 
show.  What source version are you using?

Finally, the URB.txt documentation file clearly states at the beginning 
that it is out of date.  However it wouldn't hurt to fix it up a little.  
I'll send in a patch to do so.

Alan Stern

Re: [linux-usb-devel] URB_ASYNC_UNLINK b0rkage

[Alexey Dobriyan]

On Sun, Sep 18, 2005 at 05:30:50PM -0400, Alan Stern wrote:
> On Sun, 18 Sep 2005, Alexey Dobriyan wrote:
> > drivers/usb/host/hc_crisv10.c:	if (urb->transfer_flags & URB_ASYNC_UNLINK) {
> > drivers/usb/host/hc_crisv10.c:		/* If URB_ASYNC_UNLINK is set:
> > drivers/usb/host/hc_crisv10.c:		warn("URB_ASYNC_UNLINK set, ignoring.");
> > drivers/usb/misc/uss720.c:	/* rq->urb->transfer_flags |= URB_ASYNC_UNLINK; */
> > drivers/isdn/hisax/st5481_b.c:	b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> > drivers/isdn/hisax/st5481_b.c:	b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> > drivers/isdn/hisax/st5481_usb.c:	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> > drivers/isdn/hisax/st5481_usb.c:	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> > Documentation/usb/URB.txt:the URB_ASYNC_UNLINK flag in urb->transfer flags before calling
> 
> hc_crisv10 is long out-of-date and doesn't even build, as you saw.

Just grepped.

> Is anyone still using it?  It probably should be removed from the
> Makefile.

> In my kernel tree, the st5481 source files don't include the lines you 
> show.  What source version are you using?

23 hours ago:

commit 61ffcafafb3d985e1ab8463be0187b421614775c
Author: Karsten Keil <kkeil@suse.de>
Date:   Sat Sep 17 23:52:42 2005 +0200

    [PATCH] Fix ST 5481 USB driver

    The old driver was not fully adapted to new USB ABI and does not
    work.

+	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
 	usb_unlink_urb(in->urb[0]);
+	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
 	usb_unlink_urb(in->urb[1]);

Re: [linux-usb-devel] URB_ASYNC_UNLINK b0rkage

[Greg KH]

On Mon, Sep 19, 2005 at 02:38:12AM +0400, Alexey Dobriyan wrote:
> > In my kernel tree, the st5481 source files don't include the lines you 
> > show.  What source version are you using?
> 
> 23 hours ago:
> 
> commit 61ffcafafb3d985e1ab8463be0187b421614775c
> Author: Karsten Keil <kkeil@suse.de>
> Date:   Sat Sep 17 23:52:42 2005 +0200
> 
>     [PATCH] Fix ST 5481 USB driver
> 
>     The old driver was not fully adapted to new USB ABI and does not
>     work.
> 
> +	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
>  	usb_unlink_urb(in->urb[0]);
> +	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
>  	usb_unlink_urb(in->urb[1]);

And I already pointed out that this patch was wrong, and would cause
build errors...

thanks,

greg k-h