From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Nigel Cunningham <ncunningham@cyclades.com>
Cc: Li Shaohua <shaohua.li@intel.com>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: PATCH: Fix race in cpu_down (hotplug cpu)
Date: Mon, 19 Sep 2005 12:39:35 +0530 [thread overview]
Message-ID: <20050919070935.GA9994@in.ibm.com> (raw)
In-Reply-To: <1127111495.9696.102.camel@localhost>
On Mon, Sep 19, 2005 at 04:31:36PM +1000, Nigel Cunningham wrote:
> > - } while (!need_resched());
> > + } while (!need_resched() || !cpu_is_offline(cpu));
>
> Shouldn't this be !need_resched() && !cpu_is_offline(cpu)?
Yes!
--
Thanks and Regards,
Srivatsa Vaddagiri,
Linux Technology Center,
IBM Software Labs,
Bangalore, INDIA - 560017
next prev parent reply other threads:[~2005-09-19 7:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 4:48 PATCH: Fix race in cpu_down (hotplug cpu) Li, Shaohua
2005-09-19 5:10 ` Srivatsa Vaddagiri
2005-09-19 5:31 ` Shaohua Li
2005-09-19 5:57 ` Srivatsa Vaddagiri
2005-09-19 6:11 ` Nigel Cunningham
2005-09-19 6:23 ` Srivatsa Vaddagiri
2005-09-19 6:29 ` Nick Piggin
2005-09-19 7:00 ` Srivatsa Vaddagiri
2005-09-19 6:31 ` Nigel Cunningham
2005-09-19 7:09 ` Srivatsa Vaddagiri [this message]
2005-09-19 6:37 ` Shaohua Li
2005-09-19 6:36 ` Nick Piggin
2005-09-19 6:54 ` Nigel Cunningham
2005-09-19 7:12 ` Shaohua Li
2005-09-19 7:22 ` Nick Piggin
2005-09-19 7:28 ` Ingo Molnar
2005-09-19 7:37 ` Nick Piggin
2005-09-19 22:55 ` Nigel Cunningham
2005-09-20 4:41 ` Srivatsa Vaddagiri
2005-09-19 7:07 ` Srivatsa Vaddagiri
2005-09-19 5:23 ` Nigel Cunningham
2005-09-19 5:28 ` Srivatsa Vaddagiri
2005-09-19 5:35 ` Nigel Cunningham
2005-09-19 7:43 ` Where do packets sent to 255.255.255.255 go? Wei-Che, Hsu
-- strict thread matches above, loose matches on Subject: below --
2005-09-19 3:28 PATCH: Fix race in cpu_down (hotplug cpu) Nigel Cunningham
2005-09-19 4:22 ` Srivatsa Vaddagiri
2005-09-19 3:15 Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050919070935.GA9994@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ncunningham@cyclades.com \
--cc=rusty@rustcorp.com.au \
--cc=shaohua.li@intel.com \
--cc=torvalds@osdl.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox